Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When upgrading dependency hash, fpm does not rebuild #837

Closed
certik opened this issue Feb 7, 2023 · 5 comments · Fixed by #843
Closed

When upgrading dependency hash, fpm does not rebuild #837

certik opened this issue Feb 7, 2023 · 5 comments · Fixed by #843
Assignees
Labels
bug Something isn't working

Comments

@certik
Copy link
Member

certik commented Feb 7, 2023

When I upgrade the git hash of a dependency in fpm.toml, my current project does not rebuild, and consequently the new dependency is not used. Fpm must read the hash of the dependency into the model, and if it changes, it must rebuild.

@certik certik added the bug Something isn't working label Feb 7, 2023
@certik
Copy link
Member Author

certik commented Feb 7, 2023

fpm clean
fpm run

Does NOT fix this issue. To fix it, you have to:

git clean -dfx
rm -rf build
fpm run

then it works.

This is a big bug that we have to fix soon.

@lewisfish
Copy link
Contributor

Does fpm clean --all work?

@zoziha
Copy link
Contributor

zoziha commented Feb 8, 2023

fpm update --clean should be useful, but indeed this command doesn't seem entirely intuitive.

@certik
Copy link
Member Author

certik commented Feb 8, 2023

I'll try. But that's just a workaround. Fpm I think has all the information that the hash changed and consequently the dependency now has to update.

@zoziha
Copy link
Contributor

zoziha commented Mar 6, 2023

Is it possible to update the dependency tree directly by checking the timestamp of the last modification of the fpm.toml for the top-level project?

Seems that's what meson did?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

4 participants