New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no need for alpine base/cert CA bundle copy anymore #66

Open

ldemailly opened this issue Jun 24, 2024 · 2 comments

Assignees

Member

ldemailly commented Jun 24, 2024 •

edited

Loading

with #65 merged, you should remove

https://github.com/fortio/slack-proxy/blob/main/Dockerfile#L2-L3

as it's not needed anymore: eg see https://github.com/fortio/multicurl/pull/146/files#diff-dd2c0eb6ea5cfc6c4bd4eac30934e2d5746747af48fef6da689e85b752f39557

Originally posted by @ldemailly in #65 (comment)

ldemailly assigned wiardvanrij and ani1311

Collaborator

ani1311 commented Jun 25, 2024

Okay got it. I'll clean it up.

Member Author

ldemailly commented Jun 26, 2024

I could make the MR myself (it's removing 3 lines) but wanted you guys to be aware of this shorter pure "from scratch" way

I wrote it up btw: https://laurentsv.com/blog/2024/06/25/stop-the-go-and-docker-madness.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment