Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement auth method #18

Open
wiardvanrij opened this issue Oct 22, 2023 · 2 comments
Open

Implement auth method #18

wiardvanrij opened this issue Oct 22, 2023 · 2 comments

Comments

@wiardvanrij
Copy link
Collaborator

At the moment anyone can POST against this application and it will send the message to Slack.

Ideally we implement something like a secret or a bearer token.

Open for suggestions..

@ldemailly
Copy link
Member

Can you rely on slack, as in at least 1 valid token should be used yet not used (or is validating the token counting in the flood control and thus will defeat the purpose of the proxy)

@wiardvanrij
Copy link
Collaborator Author

It's a nice idea, but I do think that it adds a bunch of additional overhead to first send a request to Slack "hey is this a valid key" to then only process the message.

Ideally I'm looking for some 'trust' model were not everyone can just POST to the proxy. Even something 'basic' like a static key would be fine?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants