Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the API usage to fetch interpreter path #635

Closed
karrtikr opened this issue Jun 26, 2020 · 7 comments
Closed

Update the API usage to fetch interpreter path #635

karrtikr opened this issue Jun 26, 2020 · 7 comments

Comments

@karrtikr
Copy link

karrtikr commented Jun 26, 2020

@formulahendry Apologies, It turns out we are updating the API again (microsoft/vscode-python#12596). You'll have to change the usage accordingly,

The PR is in review at the moment microsoft/vscode-python#12596

I'll let you know when it's finalized after which you need to publish the code runner extension.

@karrtikr
Copy link
Author

Hey there, API is finalized. Thanks for cooperating and do let me know if there's something I need to clarify.

@formulahendry
Copy link
Owner

Is the new API in insider now? Then I will start the work to integrate with it.
For thenew flag, I would call it 'usingNewPythonInterpreterPathApiV2' (https://github.com/formulahendry/vscode-code-runner/blob/master/package.json#L7). Is that OK?

@karrtikr
Copy link
Author

karrtikr commented Jul 1, 2020

Yes it is. New flag name works for me, but please don't replace the old flag, just add a new one.

@formulahendry
Copy link
Owner

Yes it is. New flag name works for me, but please don't replace the old flag, just add a new one.

Sure!

@formulahendry
Copy link
Owner

Hi @karrtikr , I have just committed the changes.
Would you please have a try on the attached vsix file and see whether everything is expected from your side?
code-runner-0.11.0-py.zip

If the changes are OK for you, I will publish a new release.

@karrtikr
Copy link
Author

karrtikr commented Jul 6, 2020

Looks good to me👍 please proceed.

@formulahendry
Copy link
Owner

Hi @karrtikr , I have just published a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants