Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bootstrap): support bootstrap 4.0.0 #680

Merged
merged 1 commit into from
Jan 25, 2018
Merged

feat(bootstrap): support bootstrap 4.0.0 #680

merged 1 commit into from
Jan 25, 2018

Conversation

aitboudad
Copy link
Member

@aitboudad aitboudad commented Jan 25, 2018

What kind of change does this PR introduce? feature

BREAKING CHANGE: bootstrap 4.0.0-beta is no longer supported.

fix #679


This change is Reviewable

BREAKING CHANGE: bootstrap 4.0.0-beta is no longer supported.

fix #679
@codecov-io
Copy link

Codecov Report

Merging #680 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #680   +/-   ##
=======================================
  Coverage   93.54%   93.54%           
=======================================
  Files          16       16           
  Lines         744      744           
  Branches      215      215           
=======================================
  Hits          696      696           
  Misses         48       48

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0199b47...7886681. Read the comment docs.

@aitboudad aitboudad merged commit 064e030 into ngx-formly:master Jan 25, 2018
@aitboudad aitboudad deleted the bootstrap-v4 branch January 25, 2018 16:54
aitboudad pushed a commit that referenced this pull request Jan 25, 2018
BREAKING CHANGE: bootstrap 4.0.0-beta is no longer supported.

fix #679

Triggered by commit: 064e030
Travis build: https://travis-ci.org/formly-js/ngx-formly/builds/333355682
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Support Bootstrap v. 4.0.0.
2 participants