Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): avoid calling deepMerge for readonly property. #626

Merged
merged 1 commit into from
Jan 4, 2018
Merged

fix(core): avoid calling deepMerge for readonly property. #626

merged 1 commit into from
Jan 4, 2018

Conversation

aitboudad
Copy link
Member

@aitboudad aitboudad commented Jan 4, 2018

What kind of change does this PR introduce? Bug fix


This change is Reviewable

@codecov-io
Copy link

Codecov Report

Merging #626 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #626      +/-   ##
==========================================
- Coverage   93.88%   93.87%   -0.01%     
==========================================
  Files          16       16              
  Lines         736      735       -1     
  Branches      211      211              
==========================================
- Hits          691      690       -1     
  Misses         45       45
Impacted Files Coverage Δ
src/core/src/components/formly.form.ts 90.62% <100%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5185f69...04c2169. Read the comment docs.

@aitboudad aitboudad merged commit 6b7987f into ngx-formly:master Jan 4, 2018
@aitboudad aitboudad deleted the updateInitialValue branch January 4, 2018 23:56
aitboudad pushed a commit that referenced this pull request Jan 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants