Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(field): remove deprecated valid prop. #537

Merged
merged 1 commit into from
Oct 26, 2017
Merged

feat(field): remove deprecated valid prop. #537

merged 1 commit into from
Oct 26, 2017

Conversation

aitboudad
Copy link
Member

@aitboudad aitboudad commented Oct 26, 2017

BREAKING CHANGE: Field::valid is no longer available, use showError instead.


This change is Reviewable

BREAKING CHANGE: `Field::valid` is no longer available, use `showError` instead.
@aitboudad aitboudad merged commit 88a9652 into ngx-formly:master Oct 26, 2017
@aitboudad aitboudad deleted the valid branch October 26, 2017 17:12
@codecov-io
Copy link

Codecov Report

Merging #537 into master will increase coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #537      +/-   ##
==========================================
+ Coverage   93.45%   93.69%   +0.24%     
==========================================
  Files          17       17              
  Lines         749      746       -3     
  Branches      210      210              
==========================================
- Hits          700      699       -1     
+ Misses         49       47       -2
Impacted Files Coverage Δ
src/core/src/templates/field.ts 100% <ø> (+11.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11b8f9b...002717b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants