Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace deprecated Renderer by Renderer2 #498

Merged
merged 1 commit into from
Aug 25, 2017
Merged

feat: replace deprecated Renderer by Renderer2 #498

merged 1 commit into from
Aug 25, 2017

Conversation

aitboudad
Copy link
Member

@aitboudad aitboudad commented Aug 25, 2017

What kind of change does this PR introduce? feature

fixed #462


This change is Reviewable


This change is Reviewable

@codecov-io
Copy link

Codecov Report

Merging #498 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #498   +/-   ##
=======================================
  Coverage   92.28%   92.28%           
=======================================
  Files          18       18           
  Lines         778      778           
  Branches      212      213    +1     
=======================================
  Hits          718      718           
  Misses         60       60
Impacted Files Coverage Δ
src/core/src/components/formly.field.ts 88.59% <100%> (ø) ⬆️
src/core/src/components/formly.attributes.ts 93.02% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2197a51...14c42ee. Read the comment docs.

@aitboudad aitboudad merged commit 0754b26 into ngx-formly:master Aug 25, 2017
@aitboudad aitboudad deleted the renderer2 branch August 25, 2017 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[v2] replace deprecated Renderer by Renderer2
3 participants