Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@formatjs/ecma402-abstract): limit accepted calendar values to 'gregory' #2618

Merged
merged 2 commits into from
Feb 20, 2021
Merged

Conversation

kachkaev
Copy link
Contributor

Fixes #2616

@kachkaev kachkaev mentioned this pull request Feb 17, 2021
@longlho
Copy link
Member

longlho commented Feb 18, 2021

@kachkaev thanks a lot for the PR. I think since we currently only support gregory calendar that might be the correct restriction tbh.

@longlho
Copy link
Member

longlho commented Feb 19, 2021

@kachkaev would you mind changing the union to just gregory and see if that builds w/ TS4.2?

@kachkaev kachkaev changed the title Fix calendar names (ethiopia → ethioaa, ethiopic-amete-alem) Fix calendar names (limit accepted values to 'gregory') Feb 19, 2021
@kachkaev
Copy link
Contributor Author

kachkaev commented Feb 19, 2021

Sorry I did not understand your first comment. I thought you meant that we were OK with my original push given that other values are not used anyway.

I hope that switching to gregory only will do the job – see TS playground with a similar example.

I’m unable to try the change locally ATM as I’m not on a work machine. The next time I’ll get access to the codebase I’ve spotted the problem in will be Monday.

@kachkaev kachkaev changed the title Fix calendar names (limit accepted values to 'gregory') Fix compatibility with TypeScript 4.2 (limit accepted calendar values to 'gregory') Feb 19, 2021
@kachkaev kachkaev changed the title Fix compatibility with TypeScript 4.2 (limit accepted calendar values to 'gregory') Fix compatibility with TS 4.2 (limit accepted calendar values to 'gregory') Feb 19, 2021
@longlho
Copy link
Member

longlho commented Feb 20, 2021

@kachkaev it's ok as long as you can push your change I can verify it :) Thanks for the PR!

@longlho longlho changed the title Fix compatibility with TS 4.2 (limit accepted calendar values to 'gregory') fix(@formatjs/ecma402-abstract): limit accepted calendar values to 'gregory' Feb 20, 2021
@longlho longlho merged commit fb3e462 into formatjs:main Feb 20, 2021
@kachkaev kachkaev deleted the patch-1 branch February 20, 2021 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type issue with TS 4.2
2 participants