fix(@formatjs/intl-numberformat): determine plurality using rounded number value #2065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyrocat101
force-pushed
the
fixNumberFormatPlural
branch
from
bf6f519 to
1a7df07
Compare
|
Can you update should-polyfill as well to account for this bug? |
|
@longlho Ok, with some digging, I think this is a bug in older versions of ICU (thus both Node 12.x and earlier versions of Chrome are affected): https://unicode-org.atlassian.net/browse/ICU-13836. The fix is introduced earlier this year: unicode-org/icu#938 Do you think it is still worth detecting such bug in the polyfill? |
|
Yeah i think we should allow polyfill to take over if we detect the bug |
|
The latest minor version of Node 12.x also ships with ICU 67.1 and thus does not have the bug. I will include the detection anyway. |
pyrocat101
force-pushed
the
fixNumberFormatPlural
branch
from
1a7df07 to
37e6718
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In earlier implementation of ES2020 Intl.NumberFormat shipped with NodeJS and Google Chrome, there was a bug that for scientific notation, the plurality of the units are determined by the mantissa:
The earlier version of the polyfill acknowledges this quirk but decided to follow its behavior. Now it seems the latest version of NodeJS and Google Chrome both have this fixed now. The polyfill will also follow the new (and IMO correct) behavior: