Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor error on SD card file detail #461

Closed
brmeadows2841 opened this issue Jan 15, 2022 · 5 comments · Fixed by #469
Closed

Minor error on SD card file detail #461

brmeadows2841 opened this issue Jan 15, 2022 · 5 comments · Fixed by #469
Assignees
Labels

Comments

@brmeadows2841
Copy link

--------- Instructions --------
Please provide answers directly below each section.
--------- Instructions ---------

ESPixelStick Firmware Version
version 4 beta 4

Hardware Version
ESP32

Binary release or compiled yourself?

compiled
Operating System (and version)
Win 11

Web Browser (and version)

Chrome
Access Point

Describe the bug
When SEQ files are uploaded to the SD card file details are incorrectly displayed.
Example:
Notice the T at end of date and Z at end of time.

Wizards in Winter -test 4.fseq | 2022-01-15T08:28:08.000Z

@MartinMueller2003
Copy link
Collaborator

That is a specific time format that conforms to the ISO time display specification. The value between the T and the Z tell you the string includes a time and that the Time Zone offset that was applied is zero.

@brmeadows2841
Copy link
Author

brmeadows2841 commented Jan 16, 2022

I understand, but it will appear weird to the average user.

@MartinMueller2003
Copy link
Collaborator

In reality the time info is almost useless since the ESP has no access to a time server (no NTP and no RTC) so the time is "taken" from the browser at the moment you transfer the files. That is at best a close approximation and at worst misleading. I suspect we may want to remove the time portion of the string.

@brmeadows2841
Copy link
Author

It would be beneficial to have a time stamp on the seq upload.

@MartinMueller2003
Copy link
Collaborator

I updated the time stamps to a more common format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants