Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When configuring from xlights leave input to fpp remote if previously selected. #388

Closed
bloojoop opened this issue Oct 13, 2021 · 4 comments
Assignees

Comments

@bloojoop
Copy link

Is your feature request related to a problem? Please describe.
I have my pixlestick configured as fpp remote. works great. If I use xlights visualizer and assign a prop, then upload outputs to configure the output settings it also changes the input to be the configured protocol (ddp in my case). I do have the inputs and output linked in xlights preferences for my other controllers. is there a way to leave it on fpp remote when uploading if that is what was set pre upload ?

Describe the solution you'd like
If selected to fpp remote, leave it on fpp remote when uploading from xlights.

Additional context
4.0 beta 3 and espixlestick v3 hardware.

@forkineye
Copy link
Owner

The underlying issue is that we consider FPP Remote mode as an input type, which isn't valid for xLights since it doesn't support FPP Multisync as an output. In order for it to work better with xLights, we'll need to move it to a secondary input or add it as a service, both which have some cons. It's a big enough issue to deserve bug status though, as it can be very annoying for people who use xLights to manage their controllers and breaks the ability to upload or play sequences once inputs are uploaded.

@forkineye forkineye added the Bug label Oct 13, 2021
@bloojoop
Copy link
Author

No worries. I have a work around and easy enough in my workflow but I can see others having fits with it. biggest thing to workaround in my mind is to NOT check the check mark on fpp connect as fpp connect gets used much more frequently than "upload outputs"
image

@MartinMueller2003
Copy link
Collaborator

In my opinion, this is an xLights bug. However, Shelby has a good idea for an enhancement that can get us part of the way. I am going to split the FSEQ support into two parts:

  1. Local File PLay gets moved to the secondary input mode of operation.
  2. Primary FPP Remote stays where it is but local file play gets removed.

Currently there is nothing stopping xLights from uploading files at any time. I suggest we tell the xLights team to add FPP Remote to the list of available input modes. Actually, they should get the list from the input_config file and present the choice list found in the config.

@MartinMueller2003
Copy link
Collaborator

I just moved the FPP Remote functionality to the secondary input. I think xLights leaves that alone. That means that xLights can set the input to DDP or E1.31 and as long as not data is received, FPP remote operation will work as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants