Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash on "Error: Invalid data provided:" #54

Closed
andrea-dintino opened this issue Feb 21, 2024 · 0 comments · Fixed by #62
Closed

Crash on "Error: Invalid data provided:" #54

andrea-dintino opened this issue Feb 21, 2024 · 0 comments · Fixed by #62
Labels
enhancement New feature or request

Comments

@andrea-dintino
Copy link
Contributor

Currently NCR crashes if wrong data type is entered in the GUI or passed via API:

https://gyazo.com/eb0653ab7beb67ff2a75744c70a263ad

The workaround I found is:

  • helper.sh < ./ncr -p 3333 --hostname myserver.com
  • pm2-start.sh < pm2 start helper.sh --name myApp

Il launching it with pm2-start.sh, pm2 diligently detects the crash and restarts the app (via helper.sh) automagically. Note (helper.sh must have .sh in the end to work in pm2)
@andrea-dintino andrea-dintino added the enhancement New feature or request label Feb 21, 2024
puria added a commit that referenced this issue Feb 27, 2024
@puria
feat: enahnce a little bit the error handling
d8a7cec 
fixes #54
@puria puria mentioned this issue Feb 27, 2024
Merged
@puria puria closed this as completed in #62 Feb 27, 2024
puria added a commit that referenced this issue Feb 27, 2024
@puria
feat: enahnce a little bit the error handling (#62)
67e33e1 
fixes #54
github-actions bot pushed a commit that referenced this issue Feb 27, 2024
@semantic-release-bot
chore(release): 🚀 1.15.0 [skip ci]
7073f92 
# [1.15.0](v1.14.2...v1.15.0) (2024-02-27)

### Features

* enahnce a little bit the error handling ([#62](#62)) ([67e33e1](67e33e1)), closes [#54](#54)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: enahnce a little bit the error handling ForkbombEu/ncr
1 participant
@andrea-dintino