Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needs to destroy camera connection when component is no longer rendered #8

Open
jfrux opened this issue Apr 14, 2017 · 4 comments
Open
Labels

Comments

@jfrux
Copy link

jfrux commented Apr 14, 2017

The component doesn't seem to destroy the camera connection when it's not rendered?
Hmm...

@jfrux
Copy link
Author

jfrux commented Apr 14, 2017

I see that on the willDestroy you're calling Webcam.reset(); but for some reason mine isn't working.
Going to do a bit more digging.

Thanks!

@leizhao4
Copy link
Collaborator

Thanks for reporting! I'll try if I can figure it out, but any suggestions or PRs are welcomed too.

@leizhao4
Copy link
Collaborator

@joshuairl I know why this is happening. The hook name should be willDestroyElement, not willDestroy. #facepalm

I'll fix this and release a new version. Please give it a try. Cheers!

@devotox
Copy link
Contributor

devotox commented Nov 2, 2017

even with willDestroyElement this does not seem to work. I think it is a bug in webcamJS but i do not know. I have multiple cameras up on the same page

@leizhao4 leizhao4 reopened this Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants