Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata for Binstall so that it can download binaries immediately (without brute forcing to find the correct URL) #1034

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

babichjacob
Copy link
Contributor

@babichjacob babichjacob commented Oct 19, 2024

I learned this from Binstall's documentation, and it fixed a similar issue with my crate.

is expected to close #1033

…y (without brute forcing to find the correct URL)
@foresterre
Copy link
Owner

Thanks!

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.99%. Comparing base (6943efe) to head (5433a6c).
Report is 36 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1034      +/-   ##
==========================================
- Coverage   75.39%   74.99%   -0.40%     
==========================================
  Files          79       80       +1     
  Lines        5458     5523      +65     
==========================================
+ Hits         4115     4142      +27     
- Misses       1343     1381      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@foresterre foresterre merged commit 3c315ee into foresterre:main Oct 19, 2024
15 checks passed
@foresterre
Copy link
Owner

How does it fetch the Cargo manifest metadata keys?

Probably from the crates.io API? (in which case it will require a release)

@babichjacob
Copy link
Contributor Author

I'll trigger another run to see if it needs a crates.io publish

@babichjacob
Copy link
Contributor Author

I don't think I fixed the issue with this pull request.

I learned that users can pass pkg-url and pkg-fmt as arguments to cargo-binstall, but it's still trying to compile cargo-msrv from source when I specify the ones I expect to work.

You can unmerge this since it didn't achieve anything, and I'll come back when I can track down whether this is unique to your crate or if there's a bug in Binstall. Sorry for the noise!

@foresterre
Copy link
Owner

No worries! Glad you reported it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo-binstall fails to install cargo-msrv on macos-latest runner
2 participants