Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sort and search issues fixes #21392 #21407

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dpgaharwal
Copy link

Fixes #21392

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

This PR introduces changes to implement filtering and sorting functionality for listings and user management. It ensures that posts can be sorted and filtered based on keywords and other criteria, delivering the expected results efficiently.


Related Tickets & Documents


QA Instructions, Screenshots, Recordings

QA Instructions

  1. Testing Filters: Navigate to the listings and admin user management sections.
  2. Apply Filters: Use the filters to sort and search posts based on keywords, roles, or statuses.
  3. Check Results: Ensure the results are sorted and filtered correctly.
  4. Edge Cases: Test scenarios with no results, invalid inputs, or a large number of records.

Screenshots/Recordings

Include screenshots of the UI changes or behavior if applicable. This is currently missing.


UI accessibility checklist

  • Semantic HTML implemented?
  • Keyboard operability supported?
  • Checked with axe DevTools and addressed Critical and Serious issues?
  • Color contrast tested?

Added/updated tests?

  • Yes
  • No, and this is why: Testing is pending; manual tests will be conducted as a follow-up.
  • I need help with writing tests.

[optional] Are there any post deployment tasks we need to perform?

  • Reindex the database if required for the filtering and sorting functionality to work efficiently.

[optional] What gif best describes this PR or how it makes you feel?

Excited Gif

@dpgaharwal dpgaharwal requested a review from a team as a code owner December 3, 2024 19:32
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Thank you for opening this PR! We appreciate you!

For all pull requests coming from third-party forks we will need to
review the PR before we can process it through our CI pipelines.

A Forem Team member will review this contribution and get back to
you as soon as possible!

Copy link
Contributor

github-actions bot commented Dec 3, 2024

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search and sort issue
1 participant