fix: metadataConverter writes zip to dir and works outside of project

[aaron-csetter]

Hello 👋 I'm an engineer from nCino. I tried adopting this tool, but it seemed to have some bugs. I went ahead and fixed them 😄 . I'll check back regularly in case something is astray. Awesome tool btw; looking forward to using it!

What does this PR do?

• Fixed a bug where output of type zip requires an sfdx-project.json file at directory root.
• Metadata conversion now writes zip to file when outputDirectory is specified in ZipConfig .

What issues does this PR fix or reference?

None because I was unable to open an issue on this repo lol.

Functionality Before

When executing the following code:

const components = resolver.getComponentsFromPath(`./sample/metadata`);
await converter.convert(components, 'metadata', {
    type: 'zip',
    outputDirectory: './out'
});

This error would occur when not within an SF project with an sfdx-project.json:

SfError [InvalidProjectWorkspaceError]: This directory does not contain a valid Salesforce DX project.

Also, even when executed in a valid project, specifying an outputDirectory would not actually write the zip to file.

Functionality After

Both of these problems are solved. The tool can be executed outside of a SF project and the zip is written to file when outputDirectory is specified.

[salesforce-cla]

Thanks for the contribution! Before we can merge this, we need @aaron-csetter to sign the Salesforce Inc. Contributor License Agreement.

[aaron-csetter]

Thanks for the contribution! Before we can merge this, we need @aaron-csetter to sign the Salesforce Inc. Contributor License Agreement.

I did but got an error 😅

[shetzel]

Looks pretty good. Thanks for the contribution. With some small changes and tests it should be all set for the rest of CI tests to run.

[shetzel]

Thanks for the contribution @aaron-csetter Look for some kudos in our release notes for an upcoming release!