Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bump jsforce, add resolution #411

Merged
merged 1 commit into from
Aug 1, 2024
Merged

fix: bump jsforce, add resolution #411

merged 1 commit into from
Aug 1, 2024

Conversation

WillieRuemmele
Copy link
Member

What does this PR do?

[skip-validate-pr]

adds resolution to move whatwg-url to latest to remove punycode deprecation warnings

@peternhale
Copy link
Collaborator

@mingxuanzhangsfdx can you look at these changes from bundling perspective?

@mingxuanzhangsfdx
Copy link
Member

whatwg-url is only used by node-fetch in jsforce-node. So it will not affect bundling.

@WillieRuemmele WillieRuemmele merged commit debfc1a into main Aug 1, 2024
17 checks passed
@WillieRuemmele WillieRuemmele deleted the wr/bumpJsforce branch August 1, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mingxuanzhangsfdx mingxuanzhangsfdx mingxuanzhangsfdx approved these changes

@peternhale peternhale peternhale approved these changes

@mshanemc mshanemc mshanemc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WillieRuemmele @peternhale @mingxuanzhangsfdx @mshanemc