fix: All Apex classes/triggers in the ApexCodeCoverageAggregate table are displayed when the "Show Only Aggregated Code Coverage" setting is checked #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ageAggregate if it is empty
…ryAll instead of fetchResults()
peternhale
requested changes
May 24, 2024
peternhale
requested changes
Jun 4, 2024
src/tests/utils.ts
Outdated
| allRecords.push(...result.records); | ||
| } | ||
|
|
||
| return { | ||
| done: true, | ||
| totalSize: allRecords.length, | ||
| records: allRecords | ||
| } as QueryResult<T>; | ||
| } as QueryResult<R>; |
There was a problem hiding this comment.
@daphne-sfdc I removed the assertion w/o complaint from elsint or others.
See if the same holds for you
There was a problem hiding this comment.
Yes you're right - I removed the assertion and the tests still all pass. The functionality also continues to work as expected. Thanks for catching that!
peternhale
approved these changes
Jun 4, 2024
peternhale
deleted the
daphne/W-15783639-show-only-aggregated-code-coverage
branch
gilgourevitch
pushed a commit
to gilgourevitch/salesforcedx-apex
that referenced
this pull request
Jun 6, 2024
… are displayed when the "Show Only Aggregated Code Coverage" setting is checked (forcedotcom#370) * fix: set apexClassIdSet to all Apex classes/triggers in ApexCodeCoverageAggregate if it is empty * refactor: query ApexCodeCoverageAggregate table only once and use queryAll instead of fetchResults() * test: update codeCoverage.test.ts to reflect new behavior * fix: use ApexCodeCoverageAggregateRecord in queryAll + add comments * refactor: use R instead of T in generics for queryAll() * test: remove assertion in test file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Populates the "Apex Code Coverage by Class" table in the Apex test results with all Apex classes/triggers listed in the ApexCodeCoverageAggregate Tooling API table when the "Show Only Aggregated Code Coverage" setting is checked.
What issues does this PR fix or reference?
forcedotcom/salesforcedx-vscode#5599, @W-15783639@
Functionality Before
When the "Show Only Aggregated Code Coverage" setting is checked, the "Apex Code Coverage by Class" table in the Apex test results is empty.
Functionality After
When the "Show Only Aggregated Code Coverage" setting is checked, the "Apex Code Coverage by Class" table in the Apex test results is populated with all available Apex classes/triggers listed in the ApexCodeCoverageAggregate Tooling API table.