feat: add heap monitoring #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@W-15760648@ add heap monitoring and class instrumentation
|
QA doc here |
@W-15724695@ @W-15760648@ Replace json stringify with bfj module Add tuning properties to streams Add env vars to adjust buffer size and json format indent
|
@CristiCanizales I am trying to resolve the broken tests, but the code should be near complete if you want to have another look. |
mshanemc
reviewed
May 23, 2024
| @@ -26,11 +28,19 @@ export class HumanFormatTransform extends Readable { | |||
| super(options); | |||
| this.testResult = testResult; | |||
| this.detailedCoverage ??= false; | |||
| this.logger = Logger.childFromRoot('HumanFormatTransform'); | |||
There was a problem hiding this comment.
what are the concerns to have this logger, given that we have HeapMonitor to log?
There was a problem hiding this comment.
No concerns. It is the same root logger that the other places where logging is done in the module.
peternhale
commented
May 24, 2024
CristiCanizales
approved these changes
Jun 3, 2024
src/utils/heapMonitor.ts
Outdated
| @@ -0,0 +1,152 @@ | |||
| /* | |||
| * Copyright (c) 2021, salesforce.com, inc. | |||
There was a problem hiding this comment.
Suggested change
| * Copyright (c) 2021, salesforce.com, inc. | |
| * Copyright (c) 2024, salesforce.com, inc. |
mingxuanzhangsfdx
approved these changes
Jun 5, 2024
| import { NamespaceInfo } from './types'; | ||
| import type { QueryResult } from '@jsforce/jsforce-node'; | ||
|
|
||
| const DEFAULT_BUFFER_SIZE = 256; | ||
| const MIN_BUFFER_SIZE = 256; | ||
| const MAX_BUFFER_SIZE = 32_768; |
There was a problem hiding this comment.
Cool. I didn't know about _ used to improve the readability of large numbers 🙂
CristiCanizales
requested changes
Jun 5, 2024
…phale/W-15760648-heap-monitor # Conflicts: # src/tests/codeCoverage.ts
CristiCanizales
approved these changes
Jun 5, 2024
gilgourevitch
pushed a commit
to gilgourevitch/salesforcedx-apex
that referenced
this pull request
Jun 6, 2024
* feat: add heap monitoring @W-15760648@ add heap monitoring and class instrumentation * chore: fix ut * chore: bump core and jsforce versions * chore: move log trace calls * chore: improve instrumentation * chore: allow only one heap monitor * chore: refactor interval assignment to c’tor * chore: bump core * chore: wip * fix: use module bfj for json string and perf tuning @W-15724695@ @W-15760648@ Replace json stringify with bfj module Add tuning properties to streams Add env vars to adjust buffer size and json format indent * chore: apply review comments * chore: fix windows ut for table * chore: fix another windows test * chore: add comments on setImmediate calls * chore: bump kit * chore: address review comments * chore: add limits to new env var values * chore: bump core to latest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
add heap monitoring and class instrumentation
What issues does this PR fix or reference?
Instrumentation only
@W-15760648@