feat!: core7 w/ jsforce-node #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peternhale
approved these changes
Apr 12, 2024
|
@mshanemc approved, but needs conflicts resolved. |
|
I'll be looking at fixing the streaming client timeout, which might be a breaking change. I'll be working off of this branch so we can bundle them together |
|
FYI : #364 |
* fix: timeout working, pjson locked, UT failing * fix: use native clearInterval * chore: undo pjson change * test: add UT
gilgourevitch
pushed a commit
to gilgourevitch/salesforcedx-apex
that referenced
this pull request
Jun 6, 2024
* test: new top-level testSetup export * feat!: core7, jsforce-node BREAKING CHANGE: use new jsforce, core * test: node16 module imports * ci: beta release 5.0.0-beta.0 * Wr/timeout apex (forcedotcom#364) * fix: timeout working, pjson locked, UT failing * fix: use native clearInterval * chore: undo pjson change * test: add UT * chore: temp beta * chore: revert to 5.0.0 * fix: allow test to finsih first and not hang * chore: temp beta * test: add assertions for test return before timeout --------- Co-authored-by: Willie Ruemmele <[email protected]> Co-authored-by: Willhoit <[email protected]> Co-authored-by: peternhale <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now with 80% less jsforce bloat!
use top-levle export for testSetup (requires some tsconfig changes to support node16 module resolution, which changes
import *stuff@W-15387805@