Please revert the progress bar

[AndrewRayCode]

It looks like the progress bar has caused numerous issues, the most interrupting of which seems to be truncating or dropping output that developers rely on to get information back from SFDX. The "workaround" of adding --json is not human friendly so it is not a workaround. On top of that, the progress bar itself apparently doesn't report the correct progress.

These issues have been open for at least two weeks now and not addressed. Could you please revert it until the issues can be addressed?

[clairebianchi]

@AndrewRayCode see my comment in #271
We hope to have the change out next week

[AndrewRayCode]

CC @clairebianchi @ntotten if we can help prioritize a revert, or if that's not an option, can we get some visibility into why this has blocked core functionality for five weeks now? Will there be a post mortem available for consumers of this library to understand how this issue has been ongoing for so long? I feel in the dark about understanding how this library is updated when there are critical issues. Could you also provide instructions for how to downgrade sfdx as a workaround until a fix is in place?

See
#274
#276
#271

[ntotten]

The fix for this was released two weeks back. You can see the info in the release notes: https://developer.salesforce.com/media/salesforce-cli/releasenotes.html

You can set an env variable SFDX_USE_PROGRESS_BAR=false to disable.

[AndrewRayCode]

@ntotten that does not work, this appears to be still broken

Command we're running:

SFDX_USE_PROGRESS_BAR=false sfdx force:source:deploy -u OurEnvironment --testlevel RunLocalTests -x manifest/package.xml

Which has this output:

It's the latest sfdx:

sfdx-cli: Updating CLI... already on latest version: 7.45.1-bc18d49798

And not sure if this is relevant:

Installing plugin salesforcedx... yarn add v1.21.1

Additionally, forcing end users to switch output type is not a fix, and is something sfdx itself should handle. All other cli tools like this detect TTY environments and don't add progress indicators that don't work in TTY environments automatically.

Again as this has been broken for so long it would be great to get more visibility into priority and understand how reverts / rollbacks happen

[clairebianchi]

@AndrewRayCode Do you have a specific version of salesforcedx plugin installed manually? You can check by running sfdx plugins. Can you please run sfdx plugins:uninstall salesforcedx and then run sfdx plugins --core?

We fixed the TTY environment issue, the progress bar should not show up for the TTY environment. The environment var is for teams that still wanted to see the old-style output in TTY environments. If you are seeing the progress bar in TTY environments then you are likely on an older version of the saelsforcedx plugin even if you have updated the Salesforce CLI.

[AndrewRayCode]

This is in a system that on every run does:

wget https://developer.salesforce.com/media/salesforce-cli/sfdx-linux-amd64.tar.xz
(then installs)

and then does

sfdx update

and then does

sfdx plugins:install salesforcedx@latest

it fully updates on every run

[clairebianchi]

@AndrewRayCode can you send me the output of when you run sfdx plugins --core?

[amphro]

We made the fix to TTY here: oclif/cli-ux@9f57d7f however it looks like we might not be depending on that version in the toolbelt. Sorry for the confusion @AndrewRayCode - well get that updated by next Thursday.

I did verify that SFDX_USE_PROGRESS_BAR is in there though. After an npm install on salesforcedx@latest, I see:

node_modules/salesforce-alm/dist/lib/mdapi/mdapiDeployReportApi.js:        // if SFDX_USE_PROGRESS_BAR is true use progress bar, if not use old output
node_modules/salesforce-alm/dist/lib/mdapi/mdapiDeployReportApi.js:        this.useProgressBar = kit_1.env.getBoolean('SFDX_USE_PROGRESS_BAR', true);

Maybe there is a bug in there but it seems to work on my end. Any additional information would help.

On a side note, you don't need to run sfdx update OR the plugin:install. The wget is pointing to the most up-to-date archive which has salesforcedx bundled in it. It would probably save some time in your CI.

[sjurgis]

This is the ridicilous output I get with progress bar disabled (iTerm/oh-my-zsh):

@clairebianchi please reopen the ticket...

[ntotten]

@sjurgis We aren't reverting the progress bar, the feedback has been overwhelmingly positive. Feel free to open a new issue explaining your problem.