Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sfdx force:package:beta console output format #1894

Closed
jbc329 opened this issue Jan 23, 2023 · 6 comments
Closed

sfdx force:package:beta console output format #1894

jbc329 opened this issue Jan 23, 2023 · 6 comments
Labels
feature Issue or pull request for a new feature

Comments

@jbc329
Copy link

jbc329 commented Jan 23, 2023

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
The new sfdx force:package:beta commands appear to produce console output which is wrapped instead of linear. A comparison of the old and new console output is below. The wrapped text makes troubleshooting console errors more difficult.
output using the beta: commands.

image

image

We are using sfdx cli version 7.180.0

What are you trying to do
A description of the outcome you are hoping to achieve
We are hoping you can modify the console output of the new sfdx force:package:beta commands to match the formatting of the previous commands.

Describe the solution you'd like
A clear and concise description of what you want to happen.
The text output on the package:beta commands would be improved if the output was similar to the previous format.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
I've considered writing custom logic around the response from the cli command to stream the output in a format we prefer.

Additional context
Add any other context or screenshots about the feature request here.
Nothing additional. Thank you!

@jbc329 jbc329 added the feature Issue or pull request for a new feature label Jan 23, 2023
@github-actions
Copy link

Thank you for filing this feature request. We appreciate your feedback and will review the feature at our next grooming or sprint planning session. We prioritize feature requests with more upvotes and comments.

@git2gus
Copy link

git2gus bot commented Jan 23, 2023

This issue has been linked to a new work item: W-12424613

@shetzel
Copy link
Contributor

shetzel commented Jan 26, 2023

@jbc329 - the newer versions of the commands use a spinner with a message that updates on every poll to minimize the amount of output a user has to visually parse. This is designed for a human and not a CI system. A few questions:

  1. Do you prefer the previous output because it's easier to read in CI output?
  2. What is the OS being used?
  3. If there was an environment variable to toggle the spinner output (and instead display poll results on a separate line each time) would that solve your usecase?

@jbc329
Copy link
Author

jbc329 commented Jan 26, 2023

Do you prefer the previous output because it's easier to read in CI output?
This the previous output was easier to read.
image

Looking at the new output, I almost suspect there is a bug. You can see the first line has a break, but the subsequent lines do not break, right? Line 151 breaks, then line 152 wraps. The text 'InitializingVersion Create' seems to be missing a break. I could be wrong and this is the intended output.
image

What is the OS being used?
In the screenshots we are using Linux Alpine in a Docker container for CI/CD. Locally, I get the same output. My local machine is running Windows 10.

If there was an environment variable to toggle the spinner output (and instead display poll results on a separate line each time) would that solve your usecase?
That would be fine.

Strange, another pipeline is showing the output similar to the previous commands.

image

@shetzel
Copy link
Contributor

shetzel commented Jan 26, 2023

The intended output is:

Screenshot 2023-01-26 at 4 09 30 PM

where a spinner is displayed just before "20 minutes ..." and that one line is updated with changes in status and time remaining. There shouldn't be multiple lines but maybe different things happen in other OS and shell combinations particularly with tee. On your local machine if you leave off the pipe to tee do you still see multiple lines or does it behave as I described?

Regardless, I think providing a way to not use a spinner might be the best of both worlds. I'll try a few things.

@shetzel
Copy link
Contributor

shetzel commented Feb 3, 2023

@jbc329 - a verbose flag was added to the command in the 7.187.1 CLI release candidate to support this usecase a little better. Feel free to try it out and let me know.

@mshanemc mshanemc closed this as completed Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Issue or pull request for a new feature
Projects
None yet
Development

No branches or pull requests

3 participants