Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support targeting specific browsers for org:open #1015

Closed
toddhalfpenny opened this issue May 17, 2021 · 5 comments
Closed

Support targeting specific browsers for org:open #1015

toddhalfpenny opened this issue May 17, 2021 · 5 comments
Labels
feature Issue or pull request for a new feature

Comments

@toddhalfpenny
Copy link

Is your feature request related to a problem? Please describe.
It is not uncommon for users of the CLI (and wrappers there of) to have mulitple browsers (e.g. Edge, Chrome, Firefox, Brave) installed and each to be used for specific projects/client etc

What are you trying to do
Would be good to be able to support being able to choose the browser application to use when opening an org with org:open

Describe the solution you'd like
It seems the open package that is used by the plugin-org supports app arguments (e,g, {app: {name: 'firefox'}}) and it seems it might make sense to be able to provide these via a flag such as (note I have just used -b below as an example);

sfdx force:org:open -b firefox -u myScratchOrg

Describe alternatives you've considered
I don't believe, other than switching the OS default browser, that this can achieved any other way

Additional context
If no one else is working on this then I'd be very happy to give this a go and raise a PR as my first towards the CLI plugins :)

@toddhalfpenny toddhalfpenny added the feature Issue or pull request for a new feature label May 17, 2021
@uip-robot-zz
Copy link

This issue has been linked to a new work item: W-9281214

@github-actions
Copy link

Thank you for filing this feature request. We appreciate your feedback and will review the feature at our next grooming or sprint planning session. We prioritize feature requests with more upvotes and comments.

@shetzel
Copy link
Contributor

shetzel commented May 17, 2021

@toddhalfpenny - we would be happy to support your PR to the org plugin. Thanks!

@SCWells72
Copy link

This can be resolved/closed now, no?

@toddhalfpenny
Copy link
Author

I would think so... sorry thought it was closed when the PR was merged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Issue or pull request for a new feature
Projects
None yet
Development

No branches or pull requests

4 participants