You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was wondering if you could add support for FileStream (or Stream in general)?
Since we usually use files for computing the CRC, I find it annoying to load the file in memory in order to get all the bytes. When you have big files, it's not really good practice. And I saw that most of libraries use the same interface as yours.
So, that's what I can do right now:
var bytes = File.ReadAllBytes(path);
var crc32 = Crc32Algorithm.Compute(bytes);
What would be nice:
using (var stream = new FileStream(path, FileMode.Open))
{
var crc32 = Crc32Algorithm.Compute(stream);
}
Thanks
The text was updated successfully, but these errors were encountered:
using (var stream = new FileStream(path, FileMode.Open))
using (var crc = new Crc32Algorithm())
{
var crc32bytes = crc.Compute(stream);
var crc32 = BitConverter.ToUInt32(crc32bytes, 0);
}
Doh, didn't realise the base class did that.
Looking at the source it's very similar to what I hacked together (right down to the 4kb buffer size).
Closing my PR as redundant.
I was wondering if you could add support for FileStream (or Stream in general)?
Since we usually use files for computing the CRC, I find it annoying to load the file in memory in order to get all the bytes. When you have big files, it's not really good practice. And I saw that most of libraries use the same interface as yours.
So, that's what I can do right now:
What would be nice:
Thanks
The text was updated successfully, but these errors were encountered: