Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move document data from document plugin to active storage #1050

Conversation

mortbauer
Copy link
Contributor

No description provided.

@yksflip
Copy link
Member

yksflip commented Mar 6, 2024

great! I've added a db migration, so existing documents are kept over this change.
Can you maybe try it out?
Otherwise this looks good to me!

@mortbauer
Copy link
Contributor Author

I actually realized that I had forgotten to commit the migration I created.
I tried yours now, the problem I face is that the migrations from the plugins directory are actually not run. Do I have to use another task as db:migrate?

@yksflip
Copy link
Member

yksflip commented Mar 8, 2024

yes you'd either need to copy it manually or run rake railties:install:migrations (see plugins/documents/README.md)

@yksflip yksflip added this to the 4.8.2 milestone Mar 11, 2024
@yksflip yksflip force-pushed the feature/move-document-plugin-to-active-storage-master branch from 39d39b0 to 9555470 Compare July 4, 2024 21:12
@yksflip
Copy link
Member

yksflip commented Jul 4, 2024

I thought it would be good to add the migration also to the default path, as the documents plugin is enabled by default and also the other plugin migrations life there ...

@yksflip yksflip force-pushed the feature/move-document-plugin-to-active-storage-master branch from 9555470 to 2cb636d Compare July 4, 2024 21:20
@yksflip yksflip merged commit 5158cec into foodcoops:master Jul 4, 2024
2 checks passed
yksflip added a commit that referenced this pull request Jul 4, 2024
* move document data from document plugin to active storage

* implement rubocoop recommendations

* add migration

* add migration to standard as documents plugin is enabled by default

---------

Co-authored-by: Philipp Rothmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants