Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[unreachable_subsetting] should not flag characters part of Google Fonts Latin core #4862

Open
mitradranirban opened this issue Oct 16, 2024 · 0 comments

Comments

@mitradranirban
Copy link

Observed behaviour

The check says
The following codepoints supported by the font are not covered by any subsets defined in the font
U+02D8 BREVE: try adding one of: yi, canadian-aboriginal
U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal
U+02DB OGONEK: try adding one of: yi, canadian-aboriginal
U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: tifinagh, math, cherokee, coptic
U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic
U+0307 COMBINING DOT ABOVE: try adding one of: hebrew, old-permic, math, todhri, canadian-aboriginal, tai-le, duployan, coptic, malayalam, syriac, tifinagh
U+030A COMBINING RING ABOVE: try adding one of: duployan, syriac
U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: osage, cherokee
U+030C COMBINING CARON: try adding one of: cherokee, tai-le
U+0326 COMBINING COMMA BELOW: try adding math
U+0327 COMBINING CEDILLA: try adding math
U+0328 COMBINING OGONEK: not included in any glyphset definition
U+0331 COMBINING MACRON BELOW: try adding one of: caucasian-albanian, sunuwar, syriac, gothic, thai, tifinagh, cherokee

Or you can add the above codepoints to one of the subsets supported by the font: devanagari, latin, latin-ext

Expected behaviour

As these charcters are part of GF Latin Core they should not be flagged

Resources and steps needed to reproduce

font Samaano https://github.com/mitradranirban/samaano-fonts
FontBakery version 0.12.10
OS Ubuntu 22.04
Python version, 3.10.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant