Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check: avar table for slnt axes #2862

Open
davelab6 opened this issue May 1, 2020 · 4 comments
Open

Add check: avar table for slnt axes #2862

davelab6 opened this issue May 1, 2020 · 4 comments
Labels
New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id Severity 1 (lowest) Something ideal to include, but that doesn't affect the font's behavior
Milestone
Leftover from lat...

Comments

@davelab6
Copy link
Contributor

davelab6 commented May 1, 2020

Observed behaviour

One of the many problems with registered axes is slnt is not a true angle. https://twitter.com/axis_praxis/status/1253281903798636546?s=19 points out this can be fixed with avar table mapping.

Expected behaviour

Therefore every variable font with an SLNT axis should have an AVAR table for that axis, and ideally the check should check that the AVAR table for the axis is correctly compensating by rerunning this kind of script to compare the results against what's in the font.
@davelab6
Copy link
Contributor Author

davelab6 commented May 6, 2020

arrowtype/recursive#59 is related

@felipesanches felipesanches added the New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id label Jun 12, 2020
@davelab6
Copy link
Contributor Author

https://twitter.com/jenskutilek/status/1083243100036837384?t=7LV3CrH0pwAtA-6T8336rA&s=19

Code is now mit

@davelab6 davelab6 added this to the 0.8.10 milestone Jul 23, 2022
@davelab6
Copy link
Contributor Author

@felipesanches lmk if you need more clarity about what this check must do

@felipesanches
Copy link
Collaborator

Sure! I'll read this early Monday, thanks!

@felipesanches felipesanches modified the milestones: 0.8.10, 0.8.11 Aug 19, 2022
@RosaWagner RosaWagner added the Severity 1 (lowest) Something ideal to include, but that doesn't affect the font's behavior label Nov 30, 2022
@RosaWagner RosaWagner modified the milestones: 0.8.11, 0.8.12 Nov 30, 2022
@felipesanches felipesanches modified the milestones: 0.8.12, 0.8.14 Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id Severity 1 (lowest) Something ideal to include, but that doesn't affect the font's behavior
Projects
None yet
Milestone
Leftover from latest dev-cycle
Development

No branches or pull requests
3 participants
@felipesanches @davelab6 @RosaWagner