Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Ignoring "expires" parameter on Contact header #245

Open
psanders opened this issue Dec 4, 2023 · 0 comments
Open

[BUG]: Ignoring "expires" parameter on Contact header #245

psanders opened this issue Dec 4, 2023 · 0 comments
Labels

Comments

@psanders
Copy link
Member

psanders commented Dec 4, 2023

What happened?

Routr is not following the protocol specified in Section "10.3 Processing REGISTER Requests" of RFC3261. It's incorrectly handling the "expires" parameter from the Contact header, which should be used to determine the expiration time. Because of this, we are having problems with SIP clients that include the expiration time in the Contact header rather than using a separate Expires header.

Steps to reproduce

  1. Build a basic UA with SIP.js (or use SimpleUser)
  2. Attempt to register with the UA
  3. At this point will see an error and the registration will fail

Expected behavior

Routr should handle the 'expires' parameter in the Contact header, and fall back to the header or a default value if none are present, as per RFC3261.

Additional context

As part of this ticket we should review the entire section 10.3 since it is likely we are missing additional aspects of registration process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant