Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Step] Fix the bad step count in a segment #92

Merged
merged 1 commit into from
Aug 16, 2018

Conversation

prudho
Copy link
Contributor

@prudho prudho commented Aug 16, 2018

Before:
22b6e3e244f87729f3e1fbd4c8ced087.md.png

After:
aec340832592ab9a5794b2ae5ab93aa2.md.png

Test case:

<div class="ui ordered steps">
  <div class="completed step">
    <div class="content">
      <div class="title">Shipping</div>
      <div class="description">Choose your shipping options</div>
    </div>
  </div>
  <div class="completed step">
    <div class="content">
      <div class="title">Billing</div>
      <div class="description">Enter billing information</div>
    </div>
  </div>
  <div class="active step">
    <div class="content">
      <div class="title">Confirm Order</div>
      <div class="description">Verify order details</div>
    </div>
  </div>
</div>

<div class="ui segment">
  <div class="ui ordered steps">
    <div class="completed step">
      <div class="content">
        <div class="title">Shipping</div>
        <div class="description">Choose your shipping options</div>
      </div>
    </div>
    <div class="completed step">
      <div class="content">
        <div class="title">Billing</div>
        <div class="description">Enter billing information</div>
      </div>
    </div>
    <div class="active step">
      <div class="content">
        <div class="title">Confirm Order</div>
        <div class="description">Verify order details</div>
      </div>
    </div>
  </div>
</div>

@prudho prudho added lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews labels Aug 16, 2018
@prudho prudho added this to the 2.5 milestone Aug 16, 2018
@y0hami y0hami requested review from y0hami and ColinFrick August 16, 2018 12:46
@y0hami y0hami removed the state/awaiting-reviews Pull requests which are waiting for reviews label Aug 16, 2018
@y0hami y0hami merged commit ac9080d into fomantic:beta Aug 16, 2018
@y0hami y0hami mentioned this pull request Sep 3, 2018
@prudho prudho deleted the fix-step-counter branch April 11, 2019 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/css Anything involving CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants