-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dropdown): values are incorrect if they contain some special chars #1210
fix(dropdown): values are incorrect if they contain some special chars #1210
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
XML-like values (e.g. Since |
@exoego |
@hammy2899 I had to fix the remove label selection as @GammaGames mentioned , so please review again. I updated the jsfiddle in the description accordingly https://jsfiddle.net/uLejd364/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Now I knew preserverHTMl
option.
@exoego @hammy2899 Please review again, i also fixed the situation when Brokenhttps://jsfiddle.net/wckbtaey/ Fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Dropdown values which are supposed to be encoded into htmlentities like
<
were wrongly encoded whenever the values changed. Especially when working with mulitple selection dropdowns.Reason for this was the overseen fact that an ampersand
&
was also encoded into&
. As htmlentities are in general encoded by starting with an ampersand aswell this was totally messing up the value string.As the escape routine was also implemented in other modules, this PR fixes the logic there as well
Testcase
Broken
https://jsfiddle.net/4cqtnf0d/
Fixed
https://jsfiddle.net/yfgwph04/
Screenshot
Closes
#1207