Replies: 1 comment
-
By removing The coloured inverted variants should remain, for example |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
We added a lot of
inverted
variants for several components which were not already available in SUI. However there are still many missing and it also isn't completely consistent everywhere.Removing all existing inverted variants would heavily reduce the codebase (yes, you already can disable the inverted variants inside https://github.com/fomantic/Fomantic-UI/blob/develop/src/themes/default/globals/variation.variables to get the same effect)
Thoughts:
inverted
logic would also mean to also support that in a dark theme (which might appear sooner or later anyway 😉), aninverted
variant inside a dark theme means to show the component in a light manner, so just as they look while using the default theme.inverted button
provide a totally different style than just being "inverted", such component variants might need a renaming insteadI wonder how many people actually mix non-inverted and inverted variants?
15 votes ·
Beta Was this translation helpful? Give feedback.
All reactions