Skip to content

Commit

Permalink
fix(dropdown): very short menu had wrong order specificity
Browse files Browse the repository at this point in the history
The very short size variation did not work. It was always overridden by the short variation because both share same specificity, thus the declaration order matters.
  • Loading branch information
lubber-de authored Sep 3, 2020
1 parent e1a8393 commit 891f6e6
Showing 1 changed file with 12 additions and 12 deletions.
24 changes: 12 additions & 12 deletions src/definitions/modules/dropdown.less
Original file line number Diff line number Diff line change
Expand Up @@ -448,12 +448,12 @@ select.ui.dropdown {

@media only screen and (max-width : @largestMobileScreen) {
& when (@variationDropdownShort) {
.ui.selection.dropdown[class*="very short"] .menu {
max-height: @selectionMobileMaxMenuHeight * 0.5;
}
.ui.selection.dropdown.short .menu {
max-height: @selectionMobileMaxMenuHeight * 0.75;
}
.ui.selection.dropdown[class*="very short"] .menu {
max-height: @selectionMobileMaxMenuHeight * 0.5;
}
}
.ui.selection.dropdown .menu {
max-height: @selectionMobileMaxMenuHeight;
Expand All @@ -469,12 +469,12 @@ select.ui.dropdown {
}
@media only screen and (min-width: @tabletBreakpoint) {
& when (@variationDropdownShort) {
.ui.selection.dropdown[class*="very short"] .menu {
max-height: @selectionTabletMaxMenuHeight * 0.5;
}
.ui.selection.dropdown.short .menu {
max-height: @selectionTabletMaxMenuHeight * 0.75;
}
.ui.selection.dropdown[class*="very short"] .menu {
max-height: @selectionTabletMaxMenuHeight * 0.5;
}
}
.ui.selection.dropdown .menu {
max-height: @selectionTabletMaxMenuHeight;
Expand All @@ -490,12 +490,12 @@ select.ui.dropdown {
}
@media only screen and (min-width: @computerBreakpoint) {
& when (@variationDropdownShort) {
.ui.selection.dropdown[class*="very short"] .menu {
max-height: @selectionComputerMaxMenuHeight * 0.5;
}
.ui.selection.dropdown.short .menu {
max-height: @selectionComputerMaxMenuHeight * 0.75;
}
.ui.selection.dropdown[class*="very short"] .menu {
max-height: @selectionComputerMaxMenuHeight * 0.5;
}
}
.ui.selection.dropdown .menu {
max-height: @selectionComputerMaxMenuHeight;
Expand All @@ -511,12 +511,12 @@ select.ui.dropdown {
}
@media only screen and (min-width: @widescreenMonitorBreakpoint) {
& when (@variationDropdownShort) {
.ui.selection.dropdown[class*="very short"] .menu {
max-height: @selectionWidescreenMaxMenuHeight * 0.5;
}
.ui.selection.dropdown.short .menu {
max-height: @selectionWidescreenMaxMenuHeight * 0.75;
}
.ui.selection.dropdown[class*="very short"] .menu {
max-height: @selectionWidescreenMaxMenuHeight * 0.5;
}
}
.ui.selection.dropdown .menu {
max-height: @selectionWidescreenMaxMenuHeight;
Expand Down

0 comments on commit 891f6e6

Please sign in to comment.