fix(chore): remove unnecessary methods and prefixes

Since 2.9.0 we limited the browser support, so many browser methods are available everywhere. There is no need to check for them beforehand so i removed those.

README.md

@@ -57,7 +57,7 @@ Fomantic includes an interactive installer to help setup your project.
 * IE 11[^2]
 * Microsoft Edge 12-44[^2]
 
-[^1]: Fomantic-UI should basically still work in iOS Safari 7+, Android 4.4+, but, starting from v2.9.0, we won't support them anymore if anything works different than in recent versions.
+[^1]: Fomantic-UI should basically still work in iOS Safari 9+, Android 4.4+, but, starting from v2.9.0, we won't support them anymore if anything works different than in recent versions.
 [^2]: Fomantic-UI should basically still work in IE11 / old Edge, but, starting from v2.9.0, we won't support them anymore in terms of dedicated bugfixes.
 
 ---

src/definitions/behaviors/api.js

@@ -977,7 +977,7 @@
                         if (moduleSelector) {
                             title += ' \'' + moduleSelector + '\'';
                         }
-                        if ((console.group !== undefined || console.table !== undefined) && performance.length > 0) {
+                        if (performance.length > 0) {
                             console.groupCollapsed(title);
                             if (console.table) {
                                 console.table(performance);

src/definitions/behaviors/form.js

@@ -1426,7 +1426,7 @@
                         if ($allModules.length > 1) {
                             title += ' (' + $allModules.length + ')';
                         }
-                        if ((console.group !== undefined || console.table !== undefined) && performance.length > 0) {
+                        if (performance.length > 0) {
                             console.groupCollapsed(title);
                             if (console.table) {
                                 console.table(performance);

src/definitions/behaviors/state.js

@@ -492,7 +492,7 @@
                         if (moduleSelector) {
                             title += ' \'' + moduleSelector + '\'';
                         }
-                        if ((console.group !== undefined || console.table !== undefined) && performance.length > 0) {
+                        if (performance.length > 0) {
                             console.groupCollapsed(title);
                             if (console.table) {
                                 console.table(performance);

src/definitions/behaviors/visibility.js

@@ -59,14 +59,6 @@
 
                 instance        = $module.data(moduleNamespace),
 
-                requestAnimationFrame = window.requestAnimationFrame
-                    || window.mozRequestAnimationFrame
-                    || window.webkitRequestAnimationFrame
-                    || window.msRequestAnimationFrame
-                    || function (callback) {
-                        setTimeout(callback, 0);
-                    },
-
                 element         = this,
                 disabled        = false,
 
@@ -1100,7 +1092,7 @@
                         if (moduleSelector) {
                             title += ' \'' + moduleSelector + '\'';
                         }
-                        if ((console.group !== undefined || console.table !== undefined) && performance.length > 0) {
+                        if (performance.length > 0) {
                             console.groupCollapsed(title);
                             if (console.table) {
                                 console.table(performance);

src/definitions/globals/site.js

@@ -60,45 +60,16 @@
             },
 
             normalize: function () {
-                module.fix.console();
-                module.fix.requestAnimationFrame();
+                // keep the function for backward compatibility
+                // eslint-disable-next-line no-useless-return
+                return;
             },
 
             fix: {
-                console: function () {
-                    module.debug('Normalizing window.console');
-                    if (console === undefined || console.log === undefined) {
-                        module.verbose('Console not available, normalizing events');
-                        module.disable.console();
-                    }
-                    if (console.group === undefined || console.groupEnd === undefined || console.groupCollapsed === undefined) {
-                        module.verbose('Console group not available, normalizing events');
-                        window.console.group = function () {};
-                        window.console.groupEnd = function () {};
-                        window.console.groupCollapsed = function () {};
-                    }
-                    if (console.markTimeline === undefined) {
-                        module.verbose('Mark timeline not available, normalizing events');
-                        window.console.markTimeline = function () {};
-                    }
-                },
                 consoleClear: function () {
                     module.debug('Disabling programmatic console clearing');
                     window.console.clear = function () {};
                 },
-                requestAnimationFrame: function () {
-                    module.debug('Normalizing requestAnimationFrame');
-                    if (window.requestAnimationFrame === undefined) {
-                        module.debug('RequestAnimationFrame not available, normalizing event');
-                        window.requestAnimationFrame = window.requestAnimationFrame
-                            || window.mozRequestAnimationFrame
-                            || window.webkitRequestAnimationFrame
-                            || window.msRequestAnimationFrame
-                            || function (callback) {
-                                setTimeout(callback, 0);
-                            };
-                    }
-                },
             },
 
             moduleExists: function (name) {
@@ -244,7 +215,7 @@
                         groupEnd: function () {},
                         info: function () {},
                         log: function () {},
-                        markTimeline: function () {},
+                        table: function () {},
                         warn: function () {},
                     };
                 }
@@ -334,7 +305,7 @@
                         totalTime += data['Execution Time'];
                     });
                     title += ' ' + totalTime + 'ms';
-                    if ((console.group !== undefined || console.table !== undefined) && performance.length > 0) {
+                    if (performance.length > 0) {
                         console.groupCollapsed(title);
                         if (console.table) {
                             console.table(performance);
@@ -441,21 +412,23 @@
             'dimmer',
             'dropdown',
             'embed',
+            'flyout',
             'form',
             'modal',
             'nag',
             'popup',
-            'slider',
+            'progress',
             'rating',
+            'search',
             'shape',
             'sidebar',
+            'slider',
             'state',
             'sticky',
             'tab',
             'toast',
             'transition',
             'visibility',
-            'visit',
         ],
 
         siteNamespace: 'site',

src/definitions/modules/accordion.js

@@ -455,7 +455,7 @@
                         if (moduleSelector) {
                             title += ' \'' + moduleSelector + '\'';
                         }
-                        if ((console.group !== undefined || console.table !== undefined) && performance.length > 0) {
+                        if (performance.length > 0) {
                             console.groupCollapsed(title);
                             if (console.table) {
                                 console.table(performance);

src/definitions/modules/calendar.js

@@ -1497,7 +1497,7 @@
                         if (moduleSelector) {
                             title += ' \'' + moduleSelector + '\'';
                         }
-                        if ((console.group !== undefined || console.table !== undefined) && performance.length > 0) {
+                        if (performance.length > 0) {
                             console.groupCollapsed(title);
                             if (console.table) {
                                 console.table(performance);

src/definitions/modules/checkbox.js

@@ -740,7 +740,7 @@
                         if (moduleSelector) {
                             title += ' \'' + moduleSelector + '\'';
                         }
-                        if ((console.group !== undefined || console.table !== undefined) && performance.length > 0) {
+                        if (performance.length > 0) {
                             console.groupCollapsed(title);
                             if (console.table) {
                                 console.table(performance);

src/definitions/modules/dimmer.js

@@ -548,7 +548,7 @@
                         if ($allModules.length > 1) {
                             title += ' (' + $allModules.length + ')';
                         }
-                        if ((console.group !== undefined || console.table !== undefined) && performance.length > 0) {
+                        if (performance.length > 0) {
                             console.groupCollapsed(title);
                             if (console.table) {
                                 console.table(performance);

src/definitions/modules/dropdown.js

@@ -3851,7 +3851,7 @@
                         if (moduleSelector) {
                             title += ' \'' + moduleSelector + '\'';
                         }
-                        if ((console.group !== undefined || console.table !== undefined) && performance.length > 0) {
+                        if (performance.length > 0) {
                             console.groupCollapsed(title);
                             if (console.table) {
                                 console.table(performance);

src/definitions/modules/embed.js

@@ -461,7 +461,7 @@
                         if ($allModules.length > 1) {
                             title += ' (' + $allModules.length + ')';
                         }
-                        if ((console.group !== undefined || console.table !== undefined) && performance.length > 0) {
+                        if (performance.length > 0) {
                             console.groupCollapsed(title);
                             if (console.table) {
                                 console.table(performance);

src/definitions/modules/flyout.js

@@ -37,14 +37,6 @@
             methodInvoked   = typeof query === 'string',
             queryArguments  = [].slice.call(arguments, 1),
 
-            requestAnimationFrame = window.requestAnimationFrame
-                || window.mozRequestAnimationFrame
-                || window.webkitRequestAnimationFrame
-                || window.msRequestAnimationFrame
-                || function (callback) {
-                    setTimeout(callback, 0);
-                },
-
             returnedValue
         ;
 
@@ -437,14 +429,12 @@
                             style += ''
                                 + ' .ui.visible.' + direction + '.flyout ~ .fixed,'
                                 + ' .ui.visible.' + direction + '.flyout ~ .pusher {'
-                                + '   -webkit-transform: translate3d(' + distance[direction] + 'px, 0, 0);'
                                 + '           transform: translate3d(' + distance[direction] + 'px, 0, 0);'
                                 + ' }';
                         } else if (direction === 'top' || direction === 'bottom') {
                             style += ''
                                 + ' .ui.visible.' + direction + '.flyout ~ .fixed,'
                                 + ' .ui.visible.' + direction + '.flyout ~ .pusher {'
-                                + '   -webkit-transform: translate3d(0, ' + distance[direction] + 'px, 0);'
                                 + '           transform: translate3d(0, ' + distance[direction] + 'px, 0);'
                                 + ' }';
                         }
@@ -456,21 +446,18 @@
                                 module.debug('Adding CSS rules for animation distance', width);
                                 style += ''
                                     + ' body.pushable > .ui.visible.' + direction + '.flyout ~ .pusher::after {'
-                                    + '   -webkit-transform: translate3d(' + distance[direction] + 'px, 0, 0);'
                                     + '           transform: translate3d(' + distance[direction] + 'px, 0, 0);'
                                     + ' }';
                             } else if (direction === 'top' || direction === 'bottom') {
                                 style += ''
                                     + ' body.pushable > .ui.visible.' + direction + '.flyout ~ .pusher::after {'
-                                    + '   -webkit-transform: translate3d(0, ' + distance[direction] + 'px, 0);'
                                     + '           transform: translate3d(0, ' + distance[direction] + 'px, 0);'
                                     + ' }';
                             }
                             /* opposite sides visible forces content overlay */
                             style += ''
                                 + ' body.pushable > .ui.visible.left.flyout ~ .ui.visible.right.flyout ~ .pusher::after,'
                                 + ' body.pushable > .ui.visible.right.flyout ~ .ui.visible.left.flyout ~ .pusher::after {'
-                                + '   -webkit-transform: translate3d(0, 0, 0);'
                                 + '           transform: translate3d(0, 0, 0);'
                                 + ' }';
                         }
@@ -1215,7 +1202,7 @@
                         if (moduleSelector) {
                             title += ' \'' + moduleSelector + '\'';
                         }
-                        if ((console.group !== undefined || console.table !== undefined) && performance.length > 0) {
+                        if (performance.length > 0) {
                             console.groupCollapsed(title);
                             if (console.table) {
                                 console.table(performance);

src/definitions/modules/modal.js

@@ -35,14 +35,6 @@
             methodInvoked  = typeof query === 'string',
             queryArguments = [].slice.call(arguments, 1),
 
-            requestAnimationFrame = window.requestAnimationFrame
-                || window.mozRequestAnimationFrame
-                || window.webkitRequestAnimationFrame
-                || window.msRequestAnimationFrame
-                || function (callback) {
-                    setTimeout(callback, 0);
-                },
-
             returnedValue
         ;
 
@@ -1221,7 +1213,7 @@
                         if (moduleSelector) {
                             title += ' \'' + moduleSelector + '\'';
                         }
-                        if ((console.group !== undefined || console.table !== undefined) && performance.length > 0) {
+                        if (performance.length > 0) {
                             console.groupCollapsed(title);
                             if (console.table) {
                                 console.table(performance);

src/definitions/modules/nag.js

@@ -382,7 +382,7 @@
                         if (moduleSelector) {
                             title += ' \'' + moduleSelector + '\'';
                         }
-                        if ((console.group !== undefined || console.table !== undefined) && performance.length > 0) {
+                        if (performance.length > 0) {
                             console.groupCollapsed(title);
                             if (console.table) {
                                 console.table(performance);

src/definitions/modules/popup.js

@@ -1238,7 +1238,7 @@
                         if (moduleSelector) {
                             title += ' \'' + moduleSelector + '\'';
                         }
-                        if ((console.group !== undefined || console.table !== undefined) && performance.length > 0) {
+                        if (performance.length > 0) {
                             console.groupCollapsed(title);
                             if (console.table) {
                                 console.table(performance);

src/definitions/modules/progress.js

@@ -835,7 +835,7 @@
                         if (moduleSelector) {
                             title += ' \'' + moduleSelector + '\'';
                         }
-                        if ((console.group !== undefined || console.table !== undefined) && performance.length > 0) {
+                        if (performance.length > 0) {
                             console.groupCollapsed(title);
                             if (console.table) {
                                 console.table(performance);

src/definitions/modules/rating.js

@@ -387,7 +387,7 @@
                         if ($allModules.length > 1) {
                             title += ' (' + $allModules.length + ')';
                         }
-                        if ((console.group !== undefined || console.table !== undefined) && performance.length > 0) {
+                        if (performance.length > 0) {
                             console.groupCollapsed(title);
                             if (console.table) {
                                 console.table(performance);

src/definitions/modules/search.js

@@ -1163,7 +1163,7 @@
                         if ($allModules.length > 1) {
                             title += ' (' + $allModules.length + ')';
                         }
-                        if ((console.group !== undefined || console.table !== undefined) && performance.length > 0) {
+                        if (performance.length > 0) {
                             console.groupCollapsed(title);
                             if (console.table) {
                                 console.table(performance);

src/definitions/modules/shape.js

@@ -30,14 +30,6 @@
             methodInvoked   = typeof query === 'string',
             queryArguments  = [].slice.call(arguments, 1),
 
-            requestAnimationFrame = window.requestAnimationFrame
-                || window.mozRequestAnimationFrame
-                || window.webkitRequestAnimationFrame
-                || window.msRequestAnimationFrame
-                || function (callback) {
-                    setTimeout(callback, 0);
-                },
-
             returnedValue
         ;
 
@@ -216,10 +208,6 @@
                         if (settings.duration || settings.duration === 0) {
                             $sides.add($side)
                                 .css({
-                                    '-webkit-transition-duration': duration,
-                                    '-moz-transition-duration': duration,
-                                    '-ms-transition-duration': duration,
-                                    '-o-transition-duration': duration,
                                     'transition-duration': duration,
                                 })
                             ;
@@ -677,7 +665,7 @@
                         if ($allModules.length > 1) {
                             title += ' (' + $allModules.length + ')';
                         }
-                        if ((console.group !== undefined || console.table !== undefined) && performance.length > 0) {
+                        if (performance.length > 0) {
                             console.groupCollapsed(title);
                             if (console.table) {
                                 console.table(performance);