diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8ec5c13a3d..31ac9766e9 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -12,7 +12,7 @@ jobs: - uses: actions/setup-node@v3 - name: Install dependencies run: yarn && yarn add -D eslint-config-airbnb-base eslint-plugin-unicorn eslint-plugin-jest@^26.9.0 @typescript-eslint/eslint-plugin @typescript-eslint/parser typescript - - name: Lint JS and CSS/LESS files + - name: Lint JS and LESS files run: npm run lint test: name: Test build process on node ${{ matrix.node-version }} @@ -33,3 +33,20 @@ jobs: run: yarn - name: pre fomantic install & gulp build run: yarn gulp install + codeql: + name: CodeQL + runs-on: ubuntu-latest + permissions: + actions: read + contents: read + security-events: write + steps: + - uses: actions/checkout@v3 + - uses: github/codeql-action/init@v2 + with: + languages: 'javascript' + config-file: ./.github/codeql/codeql-config.yml + - name: Autobuild + uses: github/codeql-action/autobuild@v2 + - name: Perform CodeQL Analysis + uses: github/codeql-action/analyze@v2 diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml deleted file mode 100644 index f5efa1ff06..0000000000 --- a/.github/workflows/codeql.yml +++ /dev/null @@ -1,68 +0,0 @@ -# For most projects, this workflow file will not need changing; you simply need -# to commit it to your repository. -# -# You may wish to alter this file to override the set of languages analyzed, -# or to provide custom queries or build logic. -# -# ******** NOTE ******** -# We have attempted to detect the languages in your repository. Please check -# the `language` matrix defined below to confirm you have the correct set of -# supported CodeQL languages. -# -name: "CodeQL" - -on: - push: - branches: [ develop ] - pull_request: - branches: [ develop ] - -jobs: - analyze: - name: Analyze - runs-on: ubuntu-latest - permissions: - actions: read - contents: read - security-events: write - - strategy: - fail-fast: false - matrix: - language: [ 'javascript' ] - # CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python', 'ruby' ] - # Learn more about CodeQL language support at https://aka.ms/codeql-docs/language-support - - steps: - - name: Checkout repository - uses: actions/checkout@v3 - - # Initializes the CodeQL tools for scanning. - - name: Initialize CodeQL - uses: github/codeql-action/init@v2 - with: - languages: ${{ matrix.language }} - config-file: ./.github/codeql/codeql-config.yml - # If you wish to specify custom queries, you can do so here or in a config file. - # By default, queries listed here will override any specified in a config file. - # Prefix the list here with "+" to use these queries and those in the config file. - # queries: ./path/to/local/query, your-org/your-repo/queries@main - - # Autobuild attempts to build any compiled languages (C/C++, C#, or Java). - # If this step fails, then you should remove it and run the build manually (see below) - - name: Autobuild - uses: github/codeql-action/autobuild@v2 - - # ℹ️ Command-line programs to run using the OS shell. - # 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun - - # ✏️ If the Autobuild fails above, remove it and uncomment the following three lines - # and modify them (or add more) to build your code if your project - # uses a compiled language - - #- run: | - # make bootstrap - # make release - - - name: Perform CodeQL Analysis - uses: github/codeql-action/analyze@v2 diff --git a/.stylelintrc.js b/.stylelintrc.js index 0d7f06856e..9d866f6f18 100644 --- a/.stylelintrc.js +++ b/.stylelintrc.js @@ -13,6 +13,7 @@ module.exports = { 'at-rule-no-unknown': null, 'block-closing-brace-newline-before': null, // fix bad formatting with "each()" 'color-function-notation': 'legacy', + 'color-hex-case': 'lower', 'declaration-block-trailing-semicolon': null, // fix bad formatting with "each()" 'function-no-unknown': null, indentation: null, // TODO change to "4" once https://github.com/fomantic/Fomantic-UI/pull/2593#discussion_r1045131096 is fixed @@ -24,7 +25,7 @@ module.exports = { 'number-max-precision': 5, 'property-case': null, 'rule-empty-line-before': null, - 'string-quotes': null, + 'string-quotes': 'double', 'value-keyword-case': null, // TODO rules to be removed/fixed in v2.10.0 as fixes are not compatible with IE11 @@ -41,9 +42,7 @@ module.exports = { 'declaration-block-no-redundant-longhand-properties': null, // 12 errors 'value-no-vendor-prefix': null, // 9 errors 'font-family-no-missing-generic-family-keyword': null, // 8 errors - 'selector-attribute-quotes': null, // 7 errors 'shorthand-property-no-redundant-values': null, // 5 errors - 'function-url-quotes': null, // 5 errors 'declaration-block-no-duplicate-properties': null, // 2 errors 'font-family-no-duplicate-names': null, // 2 errors 'function-linear-gradient-no-nonstandard-direction': null, // 1 error diff --git a/examples/components/sticky-context.html b/examples/components/sticky-context.html index e72cb3204f..da0d18548b 100644 --- a/examples/components/sticky-context.html +++ b/examples/components/sticky-context.html @@ -66,7 +66,7 @@