feat(lint): adjust LESS whitespaces to match prettier format

This PR fixes whitespaces unfixed/undetected in GH-2610 and major whitespace changes required for future Prettier integration. Double quotes and lowecased hex colors are required by Prettier - prettier/prettier#5158 - and there is no config to change it. As long as we want to use Prettier, we must accept opinionated formatting by Prettier.
fomantic · Dec 16, 2022 · 2ec6af4 · 2ec6af4
1 parent 1084e98
commit 2ec6af4
Show file tree

Hide file tree

Showing 167 changed files with 7,023 additions and 4,577 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -12,7 +12,7 @@ jobs:
     - uses: actions/setup-node@v3
     - name: Install dependencies
       run: yarn && yarn add -D eslint-config-airbnb-base eslint-plugin-unicorn eslint-plugin-jest@^26.9.0 @typescript-eslint/eslint-plugin @typescript-eslint/parser typescript
-    - name: Lint JS and CSS/LESS files
+    - name: Lint JS and LESS files
       run: npm run lint
   test:
     name: Test build process on node ${{ matrix.node-version }}
@@ -33,3 +33,20 @@ jobs:
       run: yarn
     - name: pre fomantic install & gulp build
       run: yarn gulp install
+  codeql:
+    name: CodeQL
+    runs-on: ubuntu-latest
+    permissions:
+      actions: read
+      contents: read
+      security-events: write
+    steps:
+    - uses: actions/checkout@v3
+    - uses: github/codeql-action/init@v2
+      with:
+        languages: 'javascript'
+        config-file: ./.github/codeql/codeql-config.yml
+    - name: Autobuild
+      uses: github/codeql-action/autobuild@v2
+    - name: Perform CodeQL Analysis
+      uses: github/codeql-action/analyze@v2
diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml
diff --git a/.stylelintrc.js b/.stylelintrc.js
@@ -13,6 +13,7 @@ module.exports = {
         'at-rule-no-unknown': null,
         'block-closing-brace-newline-before': null, // fix bad formatting with "each()"
         'color-function-notation': 'legacy',
+        'color-hex-case': 'lower',
         'declaration-block-trailing-semicolon': null, // fix bad formatting with "each()"
         'function-no-unknown': null,
         indentation: null, // TODO change to "4" once https://github.com/fomantic/Fomantic-UI/pull/2593#discussion_r1045131096 is fixed
@@ -24,7 +25,7 @@ module.exports = {
         'number-max-precision': 5,
         'property-case': null,
         'rule-empty-line-before': null,
-        'string-quotes': null,
+        'string-quotes': 'double',
         'value-keyword-case': null,
 
         // TODO rules to be removed/fixed in v2.10.0 as fixes are not compatible with IE11
@@ -41,9 +42,7 @@ module.exports = {
         'declaration-block-no-redundant-longhand-properties': null, // 12 errors
         'value-no-vendor-prefix': null, // 9 errors
         'font-family-no-missing-generic-family-keyword': null, // 8 errors
-        'selector-attribute-quotes': null, // 7 errors
         'shorthand-property-no-redundant-values': null, // 5 errors
-        'function-url-quotes': null, // 5 errors
         'declaration-block-no-duplicate-properties': null, // 2 errors
         'font-family-no-duplicate-names': null, // 2 errors
         'function-linear-gradient-no-nonstandard-direction': null, // 1 error

diff --git a/examples/components/sticky-context.html b/examples/components/sticky-context.html
@@ -66,7 +66,7 @@
   <style type="text/css">
 
   body {
-    background-color: #FFFFFF;
+    background-color: #fff;
   }
   .text.container {
     position: relative;

diff --git a/examples/fixed.html b/examples/fixed.html
@@ -26,7 +26,7 @@
 
   <style type="text/css">
   body {
-    background-color: #FFFFFF;
+    background-color: #fff;
   }
   .ui.menu .item img.logo {
     margin-right: 1.5em;

diff --git a/examples/grid.html b/examples/grid.html
@@ -337,7 +337,7 @@ <h3>Specifying Device Visibility</h3>
 
 /* Some basic formatting */
 code {
-  background-color: #E0E0E0;
+  background-color: #e0e0e0;
   padding: 0.25em 0.3em;
   font-family: 'Lato';
   font-weight: bold;
@@ -375,11 +375,11 @@ <h3>Specifying Device Visibility</h3>
   position: absolute;
   top: 1rem;
   left: 1rem;
-  background-color: #F0F0F0;
+  background-color: #f0f0f0;
   content: '';
   width: calc(100% - 2rem);
   height: calc(100% - 2rem);
-  box-shadow: 0px 0px 0px 1px #DDDDDD inset;
+  box-shadow: 0px 0px 0px 1px #ddd inset;
 }
 .ui.divided.grid:before,
 .celled.grid:before {

diff --git a/examples/login.html b/examples/login.html
@@ -32,7 +32,7 @@
 
   <style type="text/css">
     body {
-      background-color: #DADADA;
+      background-color: #dadada;
     }
     body > .grid {
       height: 100%;

diff --git a/examples/sticky.html b/examples/sticky.html
@@ -60,7 +60,7 @@
   <style type="text/css">
 
   body {
-    background-color: #FFFFFF;
+    background-color: #fff;
   }
   .main.container {
     margin-top: 2em;
@@ -91,8 +91,8 @@
   }
 
   .main.menu.fixed {
-    background-color: #FFFFFF;
-    border: 1px solid #DDD;
+    background-color: #fff;
+    border: 1px solid #ddd;
     box-shadow: 0px 3px 5px rgba(0, 0, 0, 0.2);
   }
   .overlay.fixed .menu {

diff --git a/src/definitions/collections/breadcrumb.less b/src/definitions/collections/breadcrumb.less
@@ -12,10 +12,10 @@
             Theme
 *******************************/
 
-@type: 'collection';
-@element: 'breadcrumb';
+@type: "collection";
+@element: "breadcrumb";
 
-@import (multiple) '../../theme.config';
+@import (multiple) "../../theme.config";
 
 /*******************************
            Breadcrumb
@@ -112,7 +112,7 @@
         .ui.@{value}.breadcrumb {
             font-size: @s;
         }
-    })
+    });
 }
 
 .loadUIOverrides();
diff --git a/src/definitions/collections/form.less b/src/definitions/collections/form.less
@@ -12,10 +12,10 @@
             Theme
 *******************************/
 
-@type: 'collection';
-@element: 'form';
+@type: "collection";
+@element: "form";
 
-@import (multiple) '../../theme.config';
+@import (multiple) "../../theme.config";
 
 /*******************************
             Elements
@@ -98,8 +98,8 @@
 }
 
 /* Set max height on unusual input */
-.ui.form::-webkit-datetime-edit,
-.ui.form::-webkit-inner-spin-button {
+.ui.form ::-webkit-datetime-edit,
+.ui.form ::-webkit-inner-spin-button {
     height: @inputLineHeight;
 }
 
@@ -281,7 +281,7 @@
 }
 
 & when (@variationFormInline) {
-    /* Inline  */
+    /* Inline */
     .ui.form .inline.fields .field:not(.wide) .ui.input,
     .ui.form .inline.field:not(.wide) .ui.input {
         width: auto;
@@ -322,7 +322,7 @@
         .ui.form .@{state}.message:empty {
             display: none;
         }
-    })
+    });
 }
 
 /* Assumptions */
@@ -383,24 +383,24 @@
 --------------------- */
 
 /* browsers require these rules separate */
-.ui.form::-webkit-input-placeholder {
+.ui.form ::-webkit-input-placeholder {
     color: @inputPlaceholderColor;
 }
-.ui.form:-ms-input-placeholder when (@supportIE) {
+.ui.form :-ms-input-placeholder when (@supportIE) {
     color: @inputPlaceholderColor !important;
 }
-.ui.form::-moz-placeholder {
+.ui.form ::-moz-placeholder {
     color: @inputPlaceholderColor;
     opacity: 1;
 }
 
-.ui.form:focus::-webkit-input-placeholder {
+.ui.form :focus::-webkit-input-placeholder {
     color: @inputPlaceholderFocusColor;
 }
-.ui.form:focus:-ms-input-placeholder when (@supportIE) {
+.ui.form :focus:-ms-input-placeholder when (@supportIE) {
     color: @inputPlaceholderFocusColor !important;
 }
-.ui.form:focus::-moz-placeholder {
+.ui.form :focus::-moz-placeholder {
     color: @inputPlaceholderFocusColor;
 }
 
@@ -740,7 +740,7 @@
                 color: @lbg;
             }
         }
-    })
+    });
 }
 
 & when (@variationFormDisabled) {
@@ -750,15 +750,15 @@
 
     .ui.form .disabled.fields .field,
     .ui.form .disabled.field,
-    .ui.form .field:disabled {
+    .ui.form .field :disabled {
         pointer-events: @disabledPointerEvents;
         opacity: @disabledOpacity;
     }
     .ui.form .field.disabled > label,
     .ui.form .fields.disabled > label {
         opacity: @disabledLabelOpacity;
     }
-    .ui.form .field.disabled:disabled {
+    .ui.form .field.disabled :disabled {
         opacity: 1;
     }
 }
@@ -775,7 +775,7 @@
     }
     .ui.loading.form::before {
         position: absolute;
-        content: '';
+        content: "";
         top: 0;
         left: 0;
         background: @loaderDimmerColor;
@@ -790,7 +790,7 @@
 
     .ui.loading.form::after {
         position: absolute;
-        content: '';
+        content: "";
         top: 50%;
         left: 50%;
         margin: @loaderMargin;
@@ -1167,7 +1167,7 @@
         .ui.@{value}.form .field .dropdown .menu > .item {
             font-size: @s;
         }
-    })
+    });
 }
 
 .loadUIOverrides();