fix(modal): remove active class on hide

Also remove the active class when a modal is hidden. This makes sure the modal doesnt keep an in between added active class if hide was called when the show transition has not already ended. The class is already removed at the start of the hiding process and it is still needed there because of CSS settings which will otherwise disturb the hide animation. This PR fixes such a specific use case
fomantic · Jan 26, 2023 · 27c5d2f · 27c5d2f
1 parent bdc9edd
commit 27c5d2f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/definitions/modules/modal.js b/src/definitions/modules/modal.js
@@ -673,6 +673,7 @@
                                     },
                                     onComplete: function () {
                                         module.unbind.scrollLock();
+                                        module.remove.active();
                                         if (settings.allowMultiple) {
                                             $previousModal.addClass(className.front);
                                             $module.removeClass(className.front);

diff --git a/src/definitions/modules/transition.js b/src/definitions/modules/transition.js
@@ -216,7 +216,7 @@
                             module.restore.conditions();
                             module.hide();
                         } else if (module.is.inward()) {
-                            module.verbose('Animation is outward, showing element');
+                            module.verbose('Animation is inward, showing element');
                             module.restore.conditions();
                             module.show();
                         } else {