Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notifier): no gap in border without title/icon #85

Merged
merged 2 commits into from
Nov 16, 2024

Conversation

dpetka2001
Copy link
Contributor

Description

Don't put padding with no title and no icon, so that there is no gap in the border.

Related Issue(s)

Fixes #84.

Screenshots

@folke folke merged commit bc80bdc into folke:main Nov 16, 2024
5 checks passed
@folke
Copy link
Owner

folke commented Nov 16, 2024

ty!

@dpetka2001 dpetka2001 deleted the fix/notifier_compact_gap_no_title branch November 16, 2024 09:05
folke pushed a commit that referenced this pull request Nov 16, 2024
🤖 I have created a release *beep* *boop*
---


## [2.1.0](v2.0.0...v2.1.0)
(2024-11-16)


### Features

* **notifier:** allow specifying a minimal level to show notifications.
See [#82](https://github.com/folke/snacks.nvim/issues/82)
([ec9cfb3](ec9cfb3))
* **terminal:** when terminal terminates too quickly, don't close the
window and show an error message. See
[#80](#80)
([313954e](313954e))


### Bug Fixes

* **docs:** typo in README.md
([#78](#78))
([dc0f404](dc0f404))
* **example:** rename file. Closes
[#76](#76)
([00c7a67](00c7a67))
* **notifier:** no gap in border without title/icon
([#85](#85))
([bc80bdc](bc80bdc))
* **win:** delay when closing windows
([#81](#81))
([d3dc8e7](d3dc8e7))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: notifier with empty title and empty icon results in gap in window border
2 participants