Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more detailed information about the compressed chunks #273

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RyuzakiKK
Copy link
Contributor

list-chunks has now a new --detailed option that allows to print additional information about the chunks, including their compressed size (if a local store is provided).

One use case is for the clients to download the server's list-chunks JSON and feed it into desync info, to calculate the precise download size of an update.

Addresses #270

cmd/desync/info.go Outdated Show resolved Hide resolved
cmd/desync/info.go Show resolved Hide resolved
cmd/desync/list.go Outdated Show resolved Hide resolved
cmd/desync/list.go Outdated Show resolved Hide resolved
cmd/desync/list.go Outdated Show resolved Hide resolved
local.go Outdated Show resolved Hide resolved
@RyuzakiKK
Copy link
Contributor Author

Thanks for the review. By the end of the week I should be able to find some time to address the points raised.

@RyuzakiKK RyuzakiKK force-pushed the precise_size branch 2 times, most recently from b4e607b to 7acdd94 Compare November 14, 2024 16:53
Copy link
Owner

@folbricht folbricht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's close, just left some minor comments

cmd/desync/inspectchunks_test.go Show resolved Hide resolved
cmd/desync/info.go Outdated Show resolved Hide resolved
cmd/desync/inspectchunks.go Outdated Show resolved Hide resolved
cmd/desync/inspectchunks.go Outdated Show resolved Hide resolved
Add a new `inspect-chunks` command that can provide additional
information about the chunks in an index, including their compressed
size (if a local store is provided).

One use case is for the clients to download the server's inspect-chunks
JSON and feed it into `desync info`, to calculate the precise download
size of an update.

Signed-off-by: Ludovico de Nittis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants