Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce duplicated data in the geoJSON #433

Open
NealHumphrey opened this issue Jul 27, 2017 · 0 comments
Open

Reduce duplicated data in the geoJSON #433

NealHumphrey opened this issue Jul 27, 2017 · 0 comments

Comments

@NealHumphrey
Copy link
Collaborator

Our 'raw_project' dataset is getting much bigger due to the addition of calculated fields, zone facts table, etc. While we probably won't have memory limit problems, it would be good to encourage developers to get their project-specific data from the 'raw_project' dataset rather than duplicating the whole thing in geoJSON as is done currently.

  • In mapView's placeProjects dataCallback (line ~600), convertToGeoJSON should only add core properties to the map geojson - i.e. anything that is used by Mapbox.

    • nlihc_id
    • lat / lon
    • proj_name, proj_addre (needed by the popup)
  • Updated the showProjectPreview to lookup the project from raw_project instead of using the passed callback data directly (row 806)

  • Check for anywhere else that the geoJson project.properties data is used and try to convert it to use raw_project instead.

If it is too time consuming to refactor all the uses of raw_project, it's OK to do a partial implementation - refactor any you find, and then switch the convertToGeoJson back to work like it used to. Future pull requests should watch out for instances of using the geojson instead of raw_project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant