Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Refactoring and Reduce Redundancy in several files #68

Open
prajwal714 opened this issue Mar 3, 2020 · 4 comments
Open

Code Refactoring and Reduce Redundancy in several files #68

prajwal714 opened this issue Mar 3, 2020 · 4 comments
Labels
CH20 Hakincodes easy For Contributors

Comments

@prajwal714
Copy link
Contributor

Make separate stateless/stateful function modules for frequently used React components. Separate JS file for validation function, also unified naming conventions of all the CSS files imported.
Components/Create/addPaths.js
Components/EditPath/editPath.js
etc
@prajwal714 prajwal714 changed the title Code Refactoring required in several files Code Refactoring and Reduce Redundancy in several files Mar 3, 2020
@vngarg
Copy link

vngarg commented Mar 4, 2020

I can work on this ....
I have some doubts -

  1. All the links also need to be changed, as the location of .js files and naming convention of .css files changes ?
  2. I can't understand the last point of changing naming conventions ?

@xlogix xlogix added easy For Contributors gssoc20 For GSSoC Contributions labels Mar 4, 2020
@prajwal714
Copy link
Contributor Author

prajwal714 commented Mar 4, 2020 •
edited
Loading

@vngarg The same css file is imported with different names, userStyles, styles etc in different js components. Unify them to a single name.

@vngarg
Copy link

vngarg commented Mar 4, 2020

@vngarg The same css file is imported with different names, userStyles, styles etc in different js components. Unify them to a single name.
ok ..
Do I have to change the links also ?

@prajwal714
Copy link
Contributor Author

Yes. Change the links too, make sure to find redundancy in other files too.

This was referenced Mar 5, 2020
Closed
Open
@xlogix xlogix added CH20 Hakincodes and removed gssoc20 For GSSoC Contributions labels Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CH20 Hakincodes easy For Contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xlogix @prajwal714 @vngarg