Feature/nil default options #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnbellone
added a commit
to johnbellone/knife-server
that referenced
this pull request
Mar 17, 2014
This is same fix as fnichol#48 expect applying it a little bit better to all of the different provisioners.
johnbellone
added a commit
to johnbellone/knife-server
that referenced
this pull request
Mar 17, 2014
This is same fix as fnichol#48 expect applying it a little bit better to all of the different provisioners.
johnbellone
added a commit
to johnbellone/knife-server
that referenced
this pull request
Mar 17, 2014
This is same fix as fnichol#48 expect applying it a little bit better to all of the different provisioners.
| @@ -72,7 +72,8 @@ def ec2_bootstrap | |||
| ENV['NO_TEST'] = "1" if config[:no_test] | |||
| bootstrap = Chef::Knife::Ec2ServerCreate.new | |||
| Chef::Knife::Ec2ServerCreate.options.keys.each do |attr| | |||
| bootstrap.config[attr] = config_val(attr) | |||
| val = config_val(attr) | |||
|
This bug effects all providers: EC2, Linode and standalone. It should really be extracted up into a parent or out into a module. |
fnichol
added a commit
that referenced
this pull request
Sep 3, 2014
|
@josephholsten you nailed it, affected all other knife plugins which 60c68e8 should address. @dldinternet I rebased this PR and merged in into master with b2520f4 . Thank you very much!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreated the pull request after fixing the check.
The idea is to check the configuration values returned and to not set options that don't have default values.