-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chrome does not ask to save login credentials #58
Comments
There is a bug for Chromium/Chrome: https://code.google.com/p/chromium/issues/detail?id=282488 |
Yea, seems to be a Chromium/Chrome bug judging from the discussion surrounding this (of which both of you guys seem to have partaken in :). I want to avoid adding an elaborate and hacky workaround for this, so I suggest we hold tight for a little longer at least till we get a response to the bug report that was submitted. |
Actually the Chromium bug was reported by an Chromium project member itself, so maybe chances are high that this Chromium developer will start to work on it some time (hopefully soon). |
I'm pretty sure this problem is beyond the scope of this repo, or even Chrome, but rather angular itself. I've only skimmed this page, but it might be the solution you're looking for http://timothy.userapp.io/post/63412334209/form-autocomplete-and-remember-password-with-angularjs |
Yea, seems like that article describes the same problem as in the bug report submitted to the Chromium project. And the fix doesn't seem to be specific to the Angular.js framework, but rather an elaborate workaround to "mock" a traditional form submission to trigger the Chrome autocomplete prompt. I still think it's best to wait and see if the bug report actually gets resolved first. Seems there are big chances of this being resolved since a Chromium team member actually submitted the report as @mkurz said. |
I just found out there is another Chromium bug report which is getting lots of attention: https://code.google.com/p/chromium/issues/detail?id=43219 |
Excellent! I guess we'll just hang tight for the moment. |
Anybody figure out a workaround? |
my solution for chrome 35.0, firefox 30.0, angular 1.2.18 (loginpage with passwordmanager, autofill, angularmethod and redirect): |
Here is the new Chromium issue: Please star it so it gains traction |
Added a star, we probably need a few more! |
This has finally been fixed in Chrome 46! 🎉 No iframe hacks anymore! Check out this example with descriptions. If you are interested there are further examples in this repo. You can run it with node: If you need help let me know. |
@fnakstad I think this issue can be closed. |
Yeah works for me now |
Using your authorization system, I am asked to save my username/pwd on FF. However, on Chrome, this is not the case.
Popular solutions to this problem for ajax-based logins utilize a hidden iframe (e.g., https://gist.github.com/kostiklv/968927) but that does not prevent the page from being reloaded, which defeats the whole purpose of an SPA.
I would be very interested to hear your thoughts on how to address this issue - it seems very odd to me that Chrome, developed by the same company that made AngularJS, doesn't play well with SPAs in this regard.
The text was updated successfully, but these errors were encountered: