Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow basic_format_args to be constructed with a dynamic set of arguments #814

Closed
MikePopoloski opened this issue Jul 17, 2018 · 2 comments
Closed

Allow basic_format_args to be constructed with a dynamic set of arguments #814

MikePopoloski opened this issue Jul 17, 2018 · 2 comments

Comments

@MikePopoloski
Copy link
Contributor

I've made this modification locally to allow dynamically specifying argument replacements: https://github.com/MikePopoloski/slang/blob/master/external/fmt/core.h#L1101

It allows usage like this: https://github.com/MikePopoloski/slang/blob/master/source/diagnostics/Diagnostics.cpp#L307
@vitaut
Copy link
Contributor

vitaut commented Jul 18, 2018

Seems reasonable, a PR is welcome.

@MikePopoloski
Copy link
Contributor Author

Cool, I can do that.

@MikePopoloski MikePopoloski mentioned this issue Jul 19, 2018
Merged
@vitaut vitaut closed this as completed Jul 21, 2018
@vitaut vitaut mentioned this issue Jul 22, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vitaut @MikePopoloski