From 24736e342b366e6ff8c4f6ba719d9944fc368e24 Mon Sep 17 00:00:00 2001 From: akhurana001 <34587798+akhurana001@users.noreply.github.com> Date: Wed, 17 Jun 2020 15:50:30 -0700 Subject: [PATCH] Bump Plugins Version (#158) * Test plugins * Update PhaseInfoInitializing * bump plugins * Bump plugins version --- go.mod | 2 +- go.sum | 5 +++-- pkg/controller/nodes/task/event_recorder_test.go | 2 +- .../nodes/task/fakeplugins/next_phase_state_plugin.go | 2 +- 4 files changed, 6 insertions(+), 5 deletions(-) diff --git a/go.mod b/go.mod index 43504bb74..701c86033 100644 --- a/go.mod +++ b/go.mod @@ -24,7 +24,7 @@ require ( github.com/jmespath/go-jmespath v0.3.0 // indirect github.com/lyft/datacatalog v0.2.1 github.com/lyft/flyteidl v0.17.32 - github.com/lyft/flyteplugins v0.3.32 + github.com/lyft/flyteplugins v0.3.33 github.com/lyft/flytestdlib v0.3.7 github.com/magiconair/properties v1.8.1 github.com/mattn/go-colorable v0.1.6 // indirect diff --git a/go.sum b/go.sum index 250b732de..a81b28422 100644 --- a/go.sum +++ b/go.sum @@ -393,8 +393,9 @@ github.com/lyft/datacatalog v0.2.1/go.mod h1:ktrPvzTDUwHO5Lv0hLH38zLHnOJ++rGoAO0 github.com/lyft/flyteidl v0.17.0/go.mod h1:/zQXxuHO11u/saxTTZc8oYExIGEShXB+xCB1/F1Cu20= github.com/lyft/flyteidl v0.17.32 h1:Iio3gYjTyPhAiOMWJ/H/4YtfWIZm5KZSlWMULT1Ef6U= github.com/lyft/flyteidl v0.17.32/go.mod h1:/zQXxuHO11u/saxTTZc8oYExIGEShXB+xCB1/F1Cu20= -github.com/lyft/flyteplugins v0.3.32 h1:+qT1apBSjZ0iAig96P+yP1/mUiklZt8VO4LVqvazZzI= -github.com/lyft/flyteplugins v0.3.32/go.mod h1:HHO6KC/2z77n9o9KM697YvSP85IWDe6jl6tAIrMLqWU= + +github.com/lyft/flyteplugins v0.3.33 h1:KlNywKdTWpGennWLjBLFnPYTQbnYOsDoQ8fZ8U3gXOQ= +github.com/lyft/flyteplugins v0.3.33/go.mod h1:HHO6KC/2z77n9o9KM697YvSP85IWDe6jl6tAIrMLqWU= github.com/lyft/flytestdlib v0.3.0/go.mod h1:LJPPJlkFj+wwVWMrQT3K5JZgNhZi2mULsCG4ZYhinhU= github.com/lyft/flytestdlib v0.3.3 h1:MkWXPkwQinh6MR3Yf5siZhmRSt9r4YmsF+5kvVVVedE= github.com/lyft/flytestdlib v0.3.3/go.mod h1:LJPPJlkFj+wwVWMrQT3K5JZgNhZi2mULsCG4ZYhinhU= diff --git a/pkg/controller/nodes/task/event_recorder_test.go b/pkg/controller/nodes/task/event_recorder_test.go index 8c857b8bd..ed98d98e9 100644 --- a/pkg/controller/nodes/task/event_recorder_test.go +++ b/pkg/controller/nodes/task/event_recorder_test.go @@ -16,7 +16,7 @@ func TestBufferedEventRecorder(t *testing.T) { assert.NotNil(t, bev) assert.Equal(t, bev.GetAll(ctx), []pluginCore.PhaseInfo{}) - ev1 := pluginCore.PhaseInfoInitializing(time.Now(), 0, "starting") + ev1 := pluginCore.PhaseInfoInitializing(time.Now(), 0, "starting", nil) assert.NoError(t, bev.RecordRaw(ctx, ev1)) assert.Equal(t, bev.GetAll(ctx), []pluginCore.PhaseInfo{ev1}) diff --git a/pkg/controller/nodes/task/fakeplugins/next_phase_state_plugin.go b/pkg/controller/nodes/task/fakeplugins/next_phase_state_plugin.go index a9bff8d1a..ec1781d26 100644 --- a/pkg/controller/nodes/task/fakeplugins/next_phase_state_plugin.go +++ b/pkg/controller/nodes/task/fakeplugins/next_phase_state_plugin.go @@ -63,7 +63,7 @@ func (n NextPhaseStatePlugin) Handle(ctx context.Context, tCtx pluginCore.TaskEx case pluginCore.PhaseNotReady: return pluginCore.DoTransition(pluginCore.PhaseInfoNotReady(time.Now(), s.PhaseVersion, "not-ready")), nil case pluginCore.PhaseInitializing: - return pluginCore.DoTransition(pluginCore.PhaseInfoInitializing(time.Now(), s.PhaseVersion, "initializing")), nil + return pluginCore.DoTransition(pluginCore.PhaseInfoInitializing(time.Now(), s.PhaseVersion, "initializing", s.TaskInfo)), nil case pluginCore.PhaseQueued: return pluginCore.DoTransition(pluginCore.PhaseInfoQueued(time.Now(), s.PhaseVersion, "queued")), nil case pluginCore.PhaseRunning: