Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added model for MPIJob #709

Closed
wants to merge 3 commits into from
Closed

Added model for MPIJob #709

wants to merge 3 commits into from

Conversation

yindia
Copy link
Contributor

@yindia yindia commented Oct 19, 2021

TL;DR

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

flyteorg/flyte#1543

Follow-up issue

NA
OR
https://github.com/lyft/flyte/issues/

Signed-off-by: Yuvraj <[email protected]>
@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #709 (7a7938a) into master (eeb66b3) will decrease coverage by 0.01%.
The diff coverage is 60.00%.

❗ Current head 7a7938a differs from pull request most recent head 321ff5d. Consider uploading reports for the commit 321ff5d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #709      +/-   ##
==========================================
- Coverage   85.72%   85.71%   -0.02%     
==========================================
  Files         357      357              
  Lines       29729    29749      +20     
  Branches     2428     2428              
==========================================
+ Hits        25486    25498      +12     
- Misses       3603     3611       +8     
  Partials      640      640              
Impacted Files Coverage Δ
flytekit/models/task.py 90.75% <60.00%> (-1.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eeb66b3...321ff5d. Read the comment docs.

Signed-off-by: Yuvraj <[email protected]>
@kumare3
Copy link
Contributor

kumare3 commented Oct 19, 2021

you do not need to add it here, it can be in the plugin repo itself

@yindia yindia closed this Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants