From 0398f3877e4165021de402b50fb454b5f8d8374c Mon Sep 17 00:00:00 2001 From: Haytham Abuelfutuh Date: Mon, 18 Jan 2021 12:29:52 -0800 Subject: [PATCH] Deprecate Log Plugins --- clients/go/coreutils/logs/cloudwatch.go | 1 + clients/go/coreutils/logs/kubernetes.go | 1 + clients/go/coreutils/logs/logs.go | 1 + clients/go/coreutils/logs/stackdriver.go | 1 + 4 files changed, 4 insertions(+) diff --git a/clients/go/coreutils/logs/cloudwatch.go b/clients/go/coreutils/logs/cloudwatch.go index 2abdb8dc8..cab017091 100644 --- a/clients/go/coreutils/logs/cloudwatch.go +++ b/clients/go/coreutils/logs/cloudwatch.go @@ -36,6 +36,7 @@ func (s cloudwatchLogPlugin) GetTaskLog(podName, namespace, containerName, conta }, nil } +// Deprecated: Please use NewTemplateLogPlugin from github.com/lyft/flyteplugins/go/tasks/pluginmachinery/tasklog instead. func NewCloudwatchLogPlugin(region, groupName string) LogPlugin { return &cloudwatchLogPlugin{ region: region, diff --git a/clients/go/coreutils/logs/kubernetes.go b/clients/go/coreutils/logs/kubernetes.go index eec9c1d42..ee791ac41 100644 --- a/clients/go/coreutils/logs/kubernetes.go +++ b/clients/go/coreutils/logs/kubernetes.go @@ -18,6 +18,7 @@ func (s kubernetesLogPlugin) GetTaskLog(podName, namespace, containerName, conta }, nil } +// Deprecated: Please use NewTemplateLogPlugin from github.com/lyft/flyteplugins/go/tasks/pluginmachinery/tasklog instead. func NewKubernetesLogPlugin(k8sURL string) LogPlugin { return &kubernetesLogPlugin{ k8sURL: k8sURL, diff --git a/clients/go/coreutils/logs/logs.go b/clients/go/coreutils/logs/logs.go index 13606a1b8..baf36631f 100644 --- a/clients/go/coreutils/logs/logs.go +++ b/clients/go/coreutils/logs/logs.go @@ -6,6 +6,7 @@ import ( "github.com/lyft/flyteidl/gen/pb-go/flyteidl/core" ) +// Deprecated: Please use Plugin interface from github.com/lyft/flyteplugins/go/tasks/pluginmachinery/tasklog instead. type LogPlugin interface { // Generates a TaskLog object given necessary computation information GetTaskLog(podName, namespace, containerName, containerID, logName string) (core.TaskLog, error) diff --git a/clients/go/coreutils/logs/stackdriver.go b/clients/go/coreutils/logs/stackdriver.go index dc1547571..91d4136b5 100644 --- a/clients/go/coreutils/logs/stackdriver.go +++ b/clients/go/coreutils/logs/stackdriver.go @@ -31,6 +31,7 @@ func (s *stackdriverLogPlugin) GetTaskLog(podName, namespace, containerName, con }, nil } +// Deprecated: Please use NewTemplateLogPlugin from github.com/lyft/flyteplugins/go/tasks/pluginmachinery/tasklog instead. func NewStackdriverLogPlugin(gcpProject, logResource string) LogPlugin { return &stackdriverLogPlugin{ gcpProject: gcpProject,