Skip to content
This repository has been archived by the owner on May 31, 2024. It is now read-only.

Adding support for ArrayNode #406

Merged
merged 4 commits into from
Jul 10, 2023
Merged

Adding support for ArrayNode #406

merged 4 commits into from
Jul 10, 2023

Conversation

hamersaw
Copy link
Contributor

TL;DR

Please replace this text with a description of what this PR accomplishes.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

^^^

Tracking Issue

flyteorg/flyte#1131

Follow-up issue

NA

@hamersaw hamersaw marked this pull request as ready for review June 29, 2023 20:30
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #406 (9927468) into master (0cb2bfa) will increase coverage by 0.73%.
The diff coverage is 0.00%.

❗ Current head 9927468 differs from pull request most recent head 630ca6d. Consider uploading reports for the commit 630ca6d to get more accurate results

@@            Coverage Diff             @@
##           master     #406      +/-   ##
==========================================
+ Coverage   66.66%   67.40%   +0.73%     
==========================================
  Files         145      145              
  Lines        6285     5249    -1036     
==========================================
- Hits         4190     3538     -652     
+ Misses       1815     1431     -384     
  Partials      280      280              
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/register/register_util.go 77.94% <0.00%> (+2.03%) ⬆️

... and 133 files with indirect coverage changes

Signed-off-by: Daniel Rammer <[email protected]>
@hamersaw hamersaw merged commit 3590432 into master Jul 10, 2023
@hamersaw hamersaw deleted the feature/array-node branch July 10, 2023 19:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants