From a5ce95c8a7684e4dd3a8494989428dbe3653343a Mon Sep 17 00:00:00 2001
From: Randy Schott <1815175+schottra@users.noreply.github.com>
Date: Tue, 7 Jul 2020 11:26:00 -0700
Subject: [PATCH 1/5] refactor: adding utility to help determine if an input
 type is supported

---
 .../inputHelpers/test/inputHelpers.test.ts    | 22 ++------
 .../inputHelpers/test/testCases.ts            | 18 +++++++
 .../inputHelpers/test/utils.test.ts           | 51 +++++++++++++++++++
 .../LaunchWorkflowForm/inputHelpers/utils.ts  | 35 ++++++++++++-
 4 files changed, 107 insertions(+), 19 deletions(-)
 create mode 100644 src/components/Launch/LaunchWorkflowForm/inputHelpers/test/utils.test.ts

diff --git a/src/components/Launch/LaunchWorkflowForm/inputHelpers/test/inputHelpers.test.ts b/src/components/Launch/LaunchWorkflowForm/inputHelpers/test/inputHelpers.test.ts
index 95ec7e687..6f1a30d14 100644
--- a/src/components/Launch/LaunchWorkflowForm/inputHelpers/test/inputHelpers.test.ts
+++ b/src/components/Launch/LaunchWorkflowForm/inputHelpers/test/inputHelpers.test.ts
@@ -12,6 +12,8 @@ import { collectionChildToString } from '../utils';
 import {
     literalTestCases,
     literalToInputTestCases,
+    supportedPrimitives,
+    unsupportedTypes,
     validityTestCases
 } from './testCases';
 
@@ -58,14 +60,7 @@ describe('literalToInputValue', () => {
             })
         );
 
-        [
-            InputType.Collection,
-            InputType.Datetime,
-            InputType.Duration,
-            InputType.Float,
-            InputType.Integer,
-            InputType.String
-        ].map(type =>
+        supportedPrimitives.map(type =>
             it(`should convert None value for ${type} to undefined`, () => {
                 expect(
                     literalToInputValue({ type }, literalNone())
@@ -176,16 +171,7 @@ describe('inputToLiteral', () => {
     });
 
     describe('Unsupported Types', () => {
-        [
-            InputType.Binary,
-            InputType.Blob,
-            InputType.Error,
-            InputType.Map,
-            InputType.None,
-            InputType.Schema,
-            InputType.Struct,
-            InputType.Unknown
-        ].map(type =>
+        unsupportedTypes.map(type =>
             it(`should return empty value for type: ${type}`, () => {
                 expect(
                     inputToLiteral(makeSimpleInput(type, '')).scalar
diff --git a/src/components/Launch/LaunchWorkflowForm/inputHelpers/test/testCases.ts b/src/components/Launch/LaunchWorkflowForm/inputHelpers/test/testCases.ts
index 8524c21c3..88180c87f 100644
--- a/src/components/Launch/LaunchWorkflowForm/inputHelpers/test/testCases.ts
+++ b/src/components/Launch/LaunchWorkflowForm/inputHelpers/test/testCases.ts
@@ -9,6 +9,24 @@ type PrimitiveTestParams = [InputType, any, Core.IPrimitive];
 
 const validDateString = '2019-01-10T00:00:00.000Z'; // Dec 1, 2019
 
+export const supportedPrimitives = [
+    InputType.Boolean,
+    InputType.Datetime,
+    InputType.Duration,
+    InputType.Float,
+    InputType.Integer
+];
+
+export const unsupportedTypes = [
+    InputType.Binary,
+    InputType.Blob,
+    InputType.Error,
+    InputType.Map,
+    InputType.None,
+    InputType.Schema,
+    InputType.Struct
+];
+
 export const validityTestCases = {
     boolean: {
         invalid: ['randomString', {}, new Date()],
diff --git a/src/components/Launch/LaunchWorkflowForm/inputHelpers/test/utils.test.ts b/src/components/Launch/LaunchWorkflowForm/inputHelpers/test/utils.test.ts
new file mode 100644
index 000000000..6671d9e00
--- /dev/null
+++ b/src/components/Launch/LaunchWorkflowForm/inputHelpers/test/utils.test.ts
@@ -0,0 +1,51 @@
+import { InputType, InputTypeDefinition } from '../../types';
+import { typeIsSupported } from '../utils';
+import { supportedPrimitives, unsupportedTypes } from './testCases';
+
+type TypeIsSupportedTestCase = [string, InputTypeDefinition, boolean];
+describe('Launch/inputHelpers/utils', () => {
+    describe('typeIsSupported', () => {
+        const cases: TypeIsSupportedTestCase[] = [
+            ...supportedPrimitives.map<TypeIsSupportedTestCase>(type => [
+                `supports type ${type}`,
+                { type },
+                true
+            ]),
+            ...supportedPrimitives.map<TypeIsSupportedTestCase>(type => [
+                `supports 1-dimension collection of type ${type}`,
+                { type: InputType.Collection, subtype: { type } },
+                true
+            ]),
+            ...supportedPrimitives.map<TypeIsSupportedTestCase>(type => [
+                `supports 2-dimension collection of type: ${type}`,
+                {
+                    type: InputType.Collection,
+                    subtype: { type: InputType.Collection, subtype: { type } }
+                },
+                true
+            ]),
+            ...unsupportedTypes.map<TypeIsSupportedTestCase>(type => [
+                `does NOT support type ${type}`,
+                { type },
+                false
+            ]),
+            ...unsupportedTypes.map<TypeIsSupportedTestCase>(type => [
+                `does NOT support 1-dimension collection of type ${type}`,
+                { type: InputType.Collection, subtype: { type } },
+                false
+            ]),
+            ...unsupportedTypes.map<TypeIsSupportedTestCase>(type => [
+                `does NOT support 2-dimension collection of type: ${type}`,
+                {
+                    type: InputType.Collection,
+                    subtype: { type: InputType.Collection, subtype: { type } }
+                },
+                false
+            ])
+        ];
+
+        cases.forEach(([description, value, expected]) =>
+            it(description, () => expect(typeIsSupported(value)).toBe(expected))
+        );
+    });
+});
diff --git a/src/components/Launch/LaunchWorkflowForm/inputHelpers/utils.ts b/src/components/Launch/LaunchWorkflowForm/inputHelpers/utils.ts
index 5b83a425a..c1695dd99 100644
--- a/src/components/Launch/LaunchWorkflowForm/inputHelpers/utils.ts
+++ b/src/components/Launch/LaunchWorkflowForm/inputHelpers/utils.ts
@@ -1,6 +1,6 @@
 import { Core } from 'flyteidl';
 import { get } from 'lodash';
-import { InputType } from '../types';
+import { InputType, InputTypeDefinition } from '../types';
 
 /** Performs a deep get of `path` on the given `Core.ILiteral`. Will throw
  * if the given property doesn't exist.
@@ -25,3 +25,36 @@ export function collectionChildToString(type: InputType, value: any) {
     }
     return type === InputType.Integer ? `${value}` : JSON.stringify(value);
 }
+
+/** Determines if a given input type, including all levels of nested types, is
+ * supported for use in the Launch form.
+ */
+export function typeIsSupported(typeDefinition: InputTypeDefinition): boolean {
+    const { type, subtype } = typeDefinition;
+    switch (type) {
+        case InputType.Map:
+        case InputType.None:
+        case InputType.Schema:
+        case InputType.Unknown:
+            return false;
+        case InputType.Boolean:
+        case InputType.Datetime:
+        case InputType.Duration:
+        case InputType.Float:
+        case InputType.Integer:
+        case InputType.String:
+            return true;
+        case InputType.Collection: {
+            if (!subtype) {
+                console.error(
+                    'Unexpected missing subtype for collection input',
+                    typeDefinition
+                );
+                return false;
+            }
+            return typeIsSupported(subtype);
+        }
+        default:
+            return false;
+    }
+}

From 4601381838018359252d0a44a02725a993cc93e1 Mon Sep 17 00:00:00 2001
From: Randy Schott <1815175+schottra@users.noreply.github.com>
Date: Mon, 13 Jul 2020 17:29:00 -0700
Subject: [PATCH 2/5] fix: adding detection and special rendering for
 unlaunchable workflows

---
 .../LaunchWorkflowForm/LaunchWorkflowForm.tsx | 31 +++++---
 .../UnsupportedRequiredInputsError.tsx        | 32 ++++++++
 .../Launch/LaunchWorkflowForm/constants.ts    |  4 +
 .../test/LaunchWorkflowForm.test.tsx          | 74 ++++++++++++++++++-
 .../LaunchWorkflowForm/test/constants.ts      |  1 +
 .../Launch/LaunchWorkflowForm/types.ts        |  1 +
 .../useLaunchWorkflowFormState.ts             |  9 +++
 .../Launch/LaunchWorkflowForm/utils.ts        | 19 ++++-
 8 files changed, 157 insertions(+), 14 deletions(-)
 create mode 100644 src/components/Launch/LaunchWorkflowForm/UnsupportedRequiredInputsError.tsx

diff --git a/src/components/Launch/LaunchWorkflowForm/LaunchWorkflowForm.tsx b/src/components/Launch/LaunchWorkflowForm/LaunchWorkflowForm.tsx
index 7d48ca917..9157d7983 100644
--- a/src/components/Launch/LaunchWorkflowForm/LaunchWorkflowForm.tsx
+++ b/src/components/Launch/LaunchWorkflowForm/LaunchWorkflowForm.tsx
@@ -16,12 +16,13 @@ import {
     workflowSortFields
 } from 'models';
 import * as React from 'react';
-import { formStrings } from './constants';
+import { formStrings, unsupportedRequiredInputsString } from './constants';
 import { InputValueCacheContext } from './inputValueCache';
 import { LaunchWorkflowFormInputs } from './LaunchWorkflowFormInputs';
 import { SearchableSelector } from './SearchableSelector';
 import { useStyles } from './styles';
 import { LaunchWorkflowFormProps } from './types';
+import { UnsupportedRequiredInputsError } from './UnsupportedRequiredInputsError';
 import { useLaunchWorkflowFormState } from './useLaunchWorkflowFormState';
 import { workflowsToSearchableSelectorOptions } from './utils';
 
@@ -67,6 +68,11 @@ export const LaunchWorkflowForm: React.FC<LaunchWorkflowFormProps> = props => {
         state.onSubmit();
     };
 
+    const preventSubmit =
+        submissionState.loading ||
+        !state.inputLoadingState.hasLoaded ||
+        state.unsupportedRequiredInputs.length > 0;
+
     return (
         <InputValueCacheContext.Provider value={state.inputValueCache}>
             <DialogTitle disableTypography={true} className={styles.header}>
@@ -114,12 +120,18 @@ export const LaunchWorkflowForm: React.FC<LaunchWorkflowFormProps> = props => {
                             {...state.inputLoadingState}
                         >
                             <section title={formStrings.inputs}>
-                                <LaunchWorkflowFormInputs
-                                    key={state.formKey}
-                                    inputs={state.inputs}
-                                    ref={state.formInputsRef}
-                                    showErrors={state.showErrors}
-                                />
+                                {state.unsupportedRequiredInputs.length > 0 ? (
+                                    <UnsupportedRequiredInputsError
+                                        inputs={state.unsupportedRequiredInputs}
+                                    />
+                                ) : (
+                                    <LaunchWorkflowFormInputs
+                                        key={state.formKey}
+                                        inputs={state.inputs}
+                                        ref={state.formInputsRef}
+                                        showErrors={state.showErrors}
+                                    />
+                                )}
                             </section>
                         </WaitForData>
                     ) : null}
@@ -143,10 +155,7 @@ export const LaunchWorkflowForm: React.FC<LaunchWorkflowFormProps> = props => {
                     </Button>
                     <Button
                         color="primary"
-                        disabled={
-                            submissionState.loading ||
-                            !state.inputLoadingState.hasLoaded
-                        }
+                        disabled={preventSubmit}
                         id="launch-workflow-submit"
                         onClick={submit}
                         type="submit"
diff --git a/src/components/Launch/LaunchWorkflowForm/UnsupportedRequiredInputsError.tsx b/src/components/Launch/LaunchWorkflowForm/UnsupportedRequiredInputsError.tsx
new file mode 100644
index 000000000..e839e288b
--- /dev/null
+++ b/src/components/Launch/LaunchWorkflowForm/UnsupportedRequiredInputsError.tsx
@@ -0,0 +1,32 @@
+import { NonIdealState } from 'components/common';
+import { useCommonStyles } from 'components/common/styles';
+import * as React from 'react';
+import {
+    cannotLaunchWorkflowString,
+    unsupportedRequiredInputsString
+} from './constants';
+import { ParsedInput } from './types';
+
+export interface UnsupportedRequiredInputsErrorProps {
+    inputs: ParsedInput[];
+}
+export const UnsupportedRequiredInputsError: React.FC<UnsupportedRequiredInputsErrorProps> = ({
+    inputs
+}) => {
+    const commonStyles = useCommonStyles();
+    return (
+        <NonIdealState
+            size="small"
+            title={cannotLaunchWorkflowString}
+            description={unsupportedRequiredInputsString}
+        >
+            <ul className={commonStyles.listUnstyled}>
+                {inputs.map(input => (
+                    <li key={input.name} className={commonStyles.textMonospace}>
+                        {input.label}
+                    </li>
+                ))}
+            </ul>
+        </NonIdealState>
+    );
+};
diff --git a/src/components/Launch/LaunchWorkflowForm/constants.ts b/src/components/Launch/LaunchWorkflowForm/constants.ts
index c7d6c1dd4..b33254cde 100644
--- a/src/components/Launch/LaunchWorkflowForm/constants.ts
+++ b/src/components/Launch/LaunchWorkflowForm/constants.ts
@@ -54,3 +54,7 @@ export const simpleTypeToInputType: { [k in SimpleType]: InputType } = {
     [SimpleType.STRING]: InputType.String,
     [SimpleType.STRUCT]: InputType.Struct
 };
+
+export const cannotLaunchWorkflowString = 'This workflow cannot be launched';
+export const unsupportedRequiredInputsString = `This Workflow version contains one or more required inputs which are not supported by Flyte Console and do not have default values specified in the workflow definition or the selected Launch Plan.\n
+You can launch this Workflow version with the Flyte CLI or by selecting a Launch Plan which provides values for the unsupported inputs.\nThe inputs are listed below:`;
diff --git a/src/components/Launch/LaunchWorkflowForm/test/LaunchWorkflowForm.test.tsx b/src/components/Launch/LaunchWorkflowForm/test/LaunchWorkflowForm.test.tsx
index 6ffaa7d65..99be2c492 100644
--- a/src/components/Launch/LaunchWorkflowForm/test/LaunchWorkflowForm.test.tsx
+++ b/src/components/Launch/LaunchWorkflowForm/test/LaunchWorkflowForm.test.tsx
@@ -34,13 +34,15 @@ import * as React from 'react';
 import { delayedPromise, pendingPromise } from 'test/utils';
 import {
     createMockWorkflowInputsInterface,
-    mockSimpleVariables
+    mockSimpleVariables,
+    simpleVariableDefaults
 } from '../__mocks__/mockInputs';
-import { formStrings } from '../constants';
+import { cannotLaunchWorkflowString, formStrings } from '../constants';
 import { LaunchWorkflowForm } from '../LaunchWorkflowForm';
 import { InitialLaunchParameters, LaunchWorkflowFormProps } from '../types';
 import { createInputCacheKey, getInputDefintionForLiteralType } from '../utils';
 import {
+    binaryInputName,
     booleanInputName,
     integerInputName,
     stringInputName,
@@ -748,4 +750,72 @@ describe('LaunchWorkflowForm', () => {
             });
         });
     });
+
+    describe('With Unsupported Required Inputs', () => {
+        beforeEach(() => {
+            variables = mockSimpleVariables;
+            createMocks();
+            // Binary is currently unsupported, setting the binary input to
+            // required and removing the default value will trigger our use case
+            const parameters = mockLaunchPlans[0].closure!.expectedInputs
+                .parameters;
+            parameters[binaryInputName].required = true;
+            delete parameters[binaryInputName].default;
+            mockGetLaunchPlan.mockResolvedValue(mockLaunchPlans[0]);
+        });
+
+        it('should render error message', async () => {
+            const { getByText } = renderForm();
+            const errorElement = await waitFor(() =>
+                getByText(cannotLaunchWorkflowString)
+            );
+            expect(errorElement).toBeInTheDocument();
+        });
+
+        it('should show unsupported inputs', async () => {
+            const { getByText } = renderForm();
+            const inputElement = await waitFor(() =>
+                getByText(binaryInputName, { exact: false })
+            );
+            expect(inputElement).toBeInTheDocument();
+        });
+
+        it('should disable submission', async () => {
+            const { getByRole } = renderForm();
+
+            const submitButton = await waitFor(() =>
+                getByRole('button', { name: formStrings.submit })
+            );
+
+            expect(submitButton).toBeDisabled();
+        });
+
+        it('should not show error if launch plan has default value', async () => {
+            mockLaunchPlans[0].closure!.expectedInputs.parameters[
+                binaryInputName
+            ].default = simpleVariableDefaults.simpleBinary as Literal;
+            const { queryByText } = renderForm();
+            await waitFor(() => queryByText(binaryInputName, { exact: false }));
+            expect(queryByText(cannotLaunchWorkflowString)).toBeNull();
+        });
+
+        it('should not show error if initial value is provided', async () => {
+            const parameters = mockLaunchPlans[0].closure!.expectedInputs
+                .parameters;
+            const values = new Map();
+            const cacheKey = createInputCacheKey(
+                binaryInputName,
+                getInputDefintionForLiteralType(
+                    parameters[binaryInputName].var.type
+                )
+            );
+            values.set(cacheKey, simpleVariableDefaults.simpleBinary);
+            const { queryByText } = renderForm({
+                initialParameters: { values }
+            });
+
+            await waitFor(() => queryByText(binaryInputName, { exact: false }));
+            expect(queryByText(cannotLaunchWorkflowString)).toBeNull();
+        });
+    });
 });
diff --git a/src/components/Launch/LaunchWorkflowForm/test/constants.ts b/src/components/Launch/LaunchWorkflowForm/test/constants.ts
index ea11fce8e..58abe6fff 100644
--- a/src/components/Launch/LaunchWorkflowForm/test/constants.ts
+++ b/src/components/Launch/LaunchWorkflowForm/test/constants.ts
@@ -2,3 +2,4 @@ export const booleanInputName = 'simpleBoolean';
 export const stringInputName = 'simpleString';
 export const stringNoLabelName = 'stringNoLabel';
 export const integerInputName = 'simpleInteger';
+export const binaryInputName = 'simpleBinary';
diff --git a/src/components/Launch/LaunchWorkflowForm/types.ts b/src/components/Launch/LaunchWorkflowForm/types.ts
index 4ebd81834..98ee7f82a 100644
--- a/src/components/Launch/LaunchWorkflowForm/types.ts
+++ b/src/components/Launch/LaunchWorkflowForm/types.ts
@@ -42,6 +42,7 @@ export interface LaunchWorkflowFormState {
     selectedWorkflow?: SearchableSelectorOption<WorkflowId>;
     showErrors: boolean;
     submissionState: FetchableData<WorkflowExecutionIdentifier>;
+    unsupportedRequiredInputs: ParsedInput[];
     workflowName: string;
     workflowOptionsLoadingState: MultiFetchableState;
     workflowSelectorOptions: SearchableSelectorOption<WorkflowId>[];
diff --git a/src/components/Launch/LaunchWorkflowForm/useLaunchWorkflowFormState.ts b/src/components/Launch/LaunchWorkflowForm/useLaunchWorkflowFormState.ts
index e5263759d..ac76049d7 100644
--- a/src/components/Launch/LaunchWorkflowForm/useLaunchWorkflowFormState.ts
+++ b/src/components/Launch/LaunchWorkflowForm/useLaunchWorkflowFormState.ts
@@ -30,6 +30,7 @@ import {
     ParsedInput
 } from './types';
 import {
+    getUnsupportedRequiredInputs,
     launchPlansToSearchableSelectorOptions,
     workflowsToSearchableSelectorOptions
 } from './utils';
@@ -50,6 +51,8 @@ function useLaunchPlanSelectorOptions(launchPlans: LaunchPlan[]) {
     ]);
 }
 
+function useUnsupportedRequiredInputs() {}
+
 interface UseLaunchPlansForWorkflowArgs {
     workflowId?: WorkflowId | null;
     preferredLaunchPlanId?: Identifier;
@@ -248,6 +251,11 @@ export function useLaunchWorkflowFormState({
 
     const [parsedInputs, setParsedInputs] = useState<ParsedInput[]>([]);
 
+    const unsupportedRequiredInputs = useMemo(
+        () => getUnsupportedRequiredInputs(parsedInputs),
+        [parsedInputs]
+    );
+
     // Any time the inputs change (even if it's just re-ordering), we must
     // change the form key so that the inputs component will re-mount.
     const formKey = useMemo<string>(() => {
@@ -421,6 +429,7 @@ export function useLaunchWorkflowFormState({
         selectedWorkflow,
         showErrors,
         submissionState,
+        unsupportedRequiredInputs,
         workflowName,
         workflowOptionsLoadingState,
         workflowSelectorOptions,
diff --git a/src/components/Launch/LaunchWorkflowForm/utils.ts b/src/components/Launch/LaunchWorkflowForm/utils.ts
index 457adcc0d..0c5d6ca23 100644
--- a/src/components/Launch/LaunchWorkflowForm/utils.ts
+++ b/src/components/Launch/LaunchWorkflowForm/utils.ts
@@ -10,8 +10,14 @@ import {
 import * as moment from 'moment';
 import { simpleTypeToInputType, typeLabels } from './constants';
 import { inputToLiteral } from './inputHelpers/inputHelpers';
+import { typeIsSupported } from './inputHelpers/utils';
 import { SearchableSelectorOption } from './SearchableSelector';
-import { InputProps, InputType, InputTypeDefinition } from './types';
+import {
+    InputProps,
+    InputType,
+    InputTypeDefinition,
+    ParsedInput
+} from './types';
 
 /** Creates a unique cache key for an input based on its name and type.
  * Note: This will not be *globally* unique, only unique within a single workflow
@@ -152,3 +158,14 @@ export function getInputDefintionForLiteralType(
 export function getLaunchInputId(name: string): string {
     return `launch-input-${name}`;
 }
+
+export function getUnsupportedRequiredInputs(
+    inputs: ParsedInput[]
+): ParsedInput[] {
+    return inputs.filter(
+        input =>
+            !typeIsSupported(input.typeDefinition) &&
+            input.required &&
+            input.initialValue === undefined
+    );
+}

From 19d3e6c697592873050a6e077f477fd798da8c25 Mon Sep 17 00:00:00 2001
From: Randy Schott <1815175+schottra@users.noreply.github.com>
Date: Wed, 15 Jul 2020 13:07:16 -0700
Subject: [PATCH 3/5] fix: implementing error message for unlaunchable
 workflows

---
 .../UnsupportedRequiredInputsError.tsx        | 45 +++++++++++++++----
 .../LaunchWorkflowForm.stories.tsx            |  8 ++++
 .../Launch/LaunchWorkflowForm/constants.ts    |  6 +--
 .../Launch/LaunchWorkflowForm/getInputs.ts    |  5 ++-
 .../Launch/LaunchWorkflowForm/styles.ts       |  1 -
 .../test/LaunchWorkflowForm.test.tsx          | 14 +++++-
 .../LaunchWorkflowForm/test/constants.ts      |  1 +
 7 files changed, 65 insertions(+), 15 deletions(-)

diff --git a/src/components/Launch/LaunchWorkflowForm/UnsupportedRequiredInputsError.tsx b/src/components/Launch/LaunchWorkflowForm/UnsupportedRequiredInputsError.tsx
index e839e288b..0e8877163 100644
--- a/src/components/Launch/LaunchWorkflowForm/UnsupportedRequiredInputsError.tsx
+++ b/src/components/Launch/LaunchWorkflowForm/UnsupportedRequiredInputsError.tsx
@@ -1,32 +1,59 @@
+import { makeStyles, Theme } from '@material-ui/core/styles';
+import ErrorOutline from '@material-ui/icons/ErrorOutline';
 import { NonIdealState } from 'components/common';
 import { useCommonStyles } from 'components/common/styles';
 import * as React from 'react';
 import {
     cannotLaunchWorkflowString,
+    requiredInputSuffix,
     unsupportedRequiredInputsString
 } from './constants';
 import { ParsedInput } from './types';
 
+const useStyles = makeStyles((theme: Theme) => ({
+    contentContainer: {
+        whiteSpace: 'pre-line',
+        textAlign: 'left'
+    },
+    errorContainer: {
+        marginBottom: theme.spacing(2)
+    }
+}));
+
+function formatLabel(label: string) {
+    return label.endsWith(requiredInputSuffix)
+        ? label.substring(0, label.length - 1)
+        : label;
+}
+
 export interface UnsupportedRequiredInputsErrorProps {
     inputs: ParsedInput[];
 }
 export const UnsupportedRequiredInputsError: React.FC<UnsupportedRequiredInputsErrorProps> = ({
     inputs
 }) => {
+    const styles = useStyles();
     const commonStyles = useCommonStyles();
     return (
         <NonIdealState
-            size="small"
+            className={styles.errorContainer}
+            icon={ErrorOutline}
+            size="medium"
             title={cannotLaunchWorkflowString}
-            description={unsupportedRequiredInputsString}
         >
-            <ul className={commonStyles.listUnstyled}>
-                {inputs.map(input => (
-                    <li key={input.name} className={commonStyles.textMonospace}>
-                        {input.label}
-                    </li>
-                ))}
-            </ul>
+            <div className={styles.contentContainer}>
+                <p>{unsupportedRequiredInputsString}</p>
+                <ul className={commonStyles.listUnstyled}>
+                    {inputs.map(input => (
+                        <li
+                            key={input.name}
+                            className={commonStyles.textMonospace}
+                        >
+                            {formatLabel(input.label)}
+                        </li>
+                    ))}
+                </ul>
+            </div>
         </NonIdealState>
     );
 };
diff --git a/src/components/Launch/LaunchWorkflowForm/__stories__/LaunchWorkflowForm.stories.tsx b/src/components/Launch/LaunchWorkflowForm/__stories__/LaunchWorkflowForm.stories.tsx
index c9e7d3138..130cdb7d1 100644
--- a/src/components/Launch/LaunchWorkflowForm/__stories__/LaunchWorkflowForm.stories.tsx
+++ b/src/components/Launch/LaunchWorkflowForm/__stories__/LaunchWorkflowForm.stories.tsx
@@ -31,6 +31,7 @@ import {
     SimpleVariableKey
 } from '../__mocks__/mockInputs';
 import { LaunchWorkflowForm } from '../LaunchWorkflowForm';
+import { binaryInputName, errorInputName } from '../test/constants';
 import { useExecutionLaunchConfiguration } from '../useExecutionLaunchConfiguration';
 import { getWorkflowInputs } from '../utils';
 
@@ -200,3 +201,10 @@ stories.add('Launched from Execution', () => {
     } as Execution;
     return renderForm({ mocks, execution });
 });
+stories.add('Unsupported Required Values', () => {
+    const mocks = generateMocks(mockSimpleVariables);
+    const parameters = mocks.mockLaunchPlan.closure!.expectedInputs.parameters;
+    parameters[binaryInputName].required = true;
+    parameters[errorInputName].required = true;
+    return renderForm({ mocks });
+});
diff --git a/src/components/Launch/LaunchWorkflowForm/constants.ts b/src/components/Launch/LaunchWorkflowForm/constants.ts
index b33254cde..068872d48 100644
--- a/src/components/Launch/LaunchWorkflowForm/constants.ts
+++ b/src/components/Launch/LaunchWorkflowForm/constants.ts
@@ -55,6 +55,6 @@ export const simpleTypeToInputType: { [k in SimpleType]: InputType } = {
     [SimpleType.STRUCT]: InputType.Struct
 };
 
-export const cannotLaunchWorkflowString = 'This workflow cannot be launched';
-export const unsupportedRequiredInputsString = `This Workflow version contains one or more required inputs which are not supported by Flyte Console and do not have default values specified in the workflow definition or the selected Launch Plan.\n
-You can launch this Workflow version with the Flyte CLI or by selecting a Launch Plan which provides values for the unsupported inputs.\nThe inputs are listed below:`;
+export const requiredInputSuffix = '*';
+export const cannotLaunchWorkflowString = 'Workflow cannot be launched';
+export const unsupportedRequiredInputsString = `This Workflow version contains one or more required inputs which are not supported by Flyte Console and do not have default values specified in the Workflow definition or the selected Launch Plan.\n\nYou can launch this Workflow version with the Flyte CLI or by selecting a Launch Plan which provides values for the unsupported inputs.\n\nThe required inputs are :`;
diff --git a/src/components/Launch/LaunchWorkflowForm/getInputs.ts b/src/components/Launch/LaunchWorkflowForm/getInputs.ts
index f760264e0..63dd7c754 100644
--- a/src/components/Launch/LaunchWorkflowForm/getInputs.ts
+++ b/src/components/Launch/LaunchWorkflowForm/getInputs.ts
@@ -1,5 +1,6 @@
 import { sortedObjectEntries } from 'common/utils';
 import { LaunchPlan, Workflow } from 'models';
+import { requiredInputSuffix } from './constants';
 import { LiteralValueMap, ParsedInput } from './types';
 import {
     createInputCacheKey,
@@ -36,7 +37,9 @@ export function getInputs(
             parameter.var.type
         );
         const typeLabel = formatLabelWithType(name, typeDefinition);
-        const label = required ? `${typeLabel}*` : typeLabel;
+        const label = required
+            ? `${typeLabel}${requiredInputSuffix}`
+            : typeLabel;
         const inputKey = createInputCacheKey(name, typeDefinition);
         const defaultVaue =
             parameter.default != null ? parameter.default : undefined;
diff --git a/src/components/Launch/LaunchWorkflowForm/styles.ts b/src/components/Launch/LaunchWorkflowForm/styles.ts
index 04a103395..50780d960 100644
--- a/src/components/Launch/LaunchWorkflowForm/styles.ts
+++ b/src/components/Launch/LaunchWorkflowForm/styles.ts
@@ -14,7 +14,6 @@ export const useStyles = makeStyles((theme: Theme) => ({
         width: '100%'
     },
     inputsSection: {
-        minHeight: theme.spacing(59),
         padding: theme.spacing(2)
     },
     inputLabel: {
diff --git a/src/components/Launch/LaunchWorkflowForm/test/LaunchWorkflowForm.test.tsx b/src/components/Launch/LaunchWorkflowForm/test/LaunchWorkflowForm.test.tsx
index 99be2c492..1af974586 100644
--- a/src/components/Launch/LaunchWorkflowForm/test/LaunchWorkflowForm.test.tsx
+++ b/src/components/Launch/LaunchWorkflowForm/test/LaunchWorkflowForm.test.tsx
@@ -37,7 +37,11 @@ import {
     mockSimpleVariables,
     simpleVariableDefaults
 } from '../__mocks__/mockInputs';
-import { cannotLaunchWorkflowString, formStrings } from '../constants';
+import {
+    cannotLaunchWorkflowString,
+    formStrings,
+    requiredInputSuffix
+} from '../constants';
 import { LaunchWorkflowForm } from '../LaunchWorkflowForm';
 import { InitialLaunchParameters, LaunchWorkflowFormProps } from '../types';
 import { createInputCacheKey, getInputDefintionForLiteralType } from '../utils';
@@ -780,6 +784,14 @@ describe('LaunchWorkflowForm', () => {
             expect(inputElement).toBeInTheDocument();
         });
 
+        it('should print input labels without decoration', async () => {
+            const { getByText } = renderForm();
+            const inputElement = await waitFor(() =>
+                getByText(binaryInputName, { exact: false })
+            );
+            expect(inputElement.textContent).not.toContain(requiredInputSuffix);
+        });
+
         it('should disable submission', async () => {
             const { getByRole } = renderForm();
 
diff --git a/src/components/Launch/LaunchWorkflowForm/test/constants.ts b/src/components/Launch/LaunchWorkflowForm/test/constants.ts
index 58abe6fff..1c7df2799 100644
--- a/src/components/Launch/LaunchWorkflowForm/test/constants.ts
+++ b/src/components/Launch/LaunchWorkflowForm/test/constants.ts
@@ -3,3 +3,4 @@ export const stringInputName = 'simpleString';
 export const stringNoLabelName = 'stringNoLabel';
 export const integerInputName = 'simpleInteger';
 export const binaryInputName = 'simpleBinary';
+export const errorInputName = 'simpleError';

From da634572eeaf835d24b329abdbf17cea4d6420e5 Mon Sep 17 00:00:00 2001
From: Randy Schott <1815175+schottra@users.noreply.github.com>
Date: Wed, 15 Jul 2020 13:15:43 -0700
Subject: [PATCH 4/5] chore: docs

---
 .../LaunchWorkflowForm/UnsupportedRequiredInputsError.tsx      | 3 +++
 src/components/Launch/LaunchWorkflowForm/utils.ts              | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/src/components/Launch/LaunchWorkflowForm/UnsupportedRequiredInputsError.tsx b/src/components/Launch/LaunchWorkflowForm/UnsupportedRequiredInputsError.tsx
index 0e8877163..6d31b61d0 100644
--- a/src/components/Launch/LaunchWorkflowForm/UnsupportedRequiredInputsError.tsx
+++ b/src/components/Launch/LaunchWorkflowForm/UnsupportedRequiredInputsError.tsx
@@ -29,6 +29,9 @@ function formatLabel(label: string) {
 export interface UnsupportedRequiredInputsErrorProps {
     inputs: ParsedInput[];
 }
+/** An informational error to be shown if a Workflow cannot be launch due to
+ * required inputs for which we will not be able to provide a value.
+ */
 export const UnsupportedRequiredInputsError: React.FC<UnsupportedRequiredInputsErrorProps> = ({
     inputs
 }) => {
diff --git a/src/components/Launch/LaunchWorkflowForm/utils.ts b/src/components/Launch/LaunchWorkflowForm/utils.ts
index 0c5d6ca23..fc8fae3c4 100644
--- a/src/components/Launch/LaunchWorkflowForm/utils.ts
+++ b/src/components/Launch/LaunchWorkflowForm/utils.ts
@@ -159,6 +159,9 @@ export function getLaunchInputId(name: string): string {
     return `launch-input-${name}`;
 }
 
+/** Given an array of `ParsedInput`s, returns the subset which are required
+ * and of a type which cannot be provided via our form.
+ */
 export function getUnsupportedRequiredInputs(
     inputs: ParsedInput[]
 ): ParsedInput[] {

From b4fe2ebbb71b5d54024d1d92a2e9a765fef14e10 Mon Sep 17 00:00:00 2001
From: Randy Schott <1815175+schottra@users.noreply.github.com>
Date: Wed, 15 Jul 2020 14:29:12 -0700
Subject: [PATCH 5/5] chore: pr feedback

---
 src/common/utils.ts                             | 17 +++++++++++++++++
 .../LaunchWorkflowForm/inputHelpers/utils.ts    |  8 ++++++++
 .../useLaunchWorkflowFormState.ts               |  2 --
 3 files changed, 25 insertions(+), 2 deletions(-)

diff --git a/src/common/utils.ts b/src/common/utils.ts
index cdf07cb5b..c637e21d1 100644
--- a/src/common/utils.ts
+++ b/src/common/utils.ts
@@ -99,3 +99,20 @@ export function sortedObjectKeys(
 ): ReturnType<typeof Object.keys> {
     return Object.keys(object).sort((a, b) => a.localeCompare(b));
 }
+
+/**
+ * Helper function for exhaustive checks of discriminated unions.
+ * https://basarat.gitbooks.io/typescript/docs/types/discriminated-unions.html
+ */
+export function assertNever(
+    value: never,
+    { noThrow }: { noThrow?: boolean } = {}
+): never {
+    if (noThrow) {
+        return value;
+    }
+
+    throw new Error(
+        `Unhandled discriminated union member: ${JSON.stringify(value)}`
+    );
+}
diff --git a/src/components/Launch/LaunchWorkflowForm/inputHelpers/utils.ts b/src/components/Launch/LaunchWorkflowForm/inputHelpers/utils.ts
index c1695dd99..3dcf5d850 100644
--- a/src/components/Launch/LaunchWorkflowForm/inputHelpers/utils.ts
+++ b/src/components/Launch/LaunchWorkflowForm/inputHelpers/utils.ts
@@ -1,3 +1,4 @@
+import { assertNever } from 'common/utils';
 import { Core } from 'flyteidl';
 import { get } from 'lodash';
 import { InputType, InputTypeDefinition } from '../types';
@@ -32,9 +33,13 @@ export function collectionChildToString(type: InputType, value: any) {
 export function typeIsSupported(typeDefinition: InputTypeDefinition): boolean {
     const { type, subtype } = typeDefinition;
     switch (type) {
+        case InputType.Binary:
+        case InputType.Blob:
+        case InputType.Error:
         case InputType.Map:
         case InputType.None:
         case InputType.Schema:
+        case InputType.Struct:
         case InputType.Unknown:
             return false;
         case InputType.Boolean:
@@ -55,6 +60,9 @@ export function typeIsSupported(typeDefinition: InputTypeDefinition): boolean {
             return typeIsSupported(subtype);
         }
         default:
+            // This will cause a compiler error if new types are added and there is
+            // no case for them listed above.
+            assertNever(type, { noThrow: true });
             return false;
     }
 }
diff --git a/src/components/Launch/LaunchWorkflowForm/useLaunchWorkflowFormState.ts b/src/components/Launch/LaunchWorkflowForm/useLaunchWorkflowFormState.ts
index ac76049d7..1ac2741f7 100644
--- a/src/components/Launch/LaunchWorkflowForm/useLaunchWorkflowFormState.ts
+++ b/src/components/Launch/LaunchWorkflowForm/useLaunchWorkflowFormState.ts
@@ -51,8 +51,6 @@ function useLaunchPlanSelectorOptions(launchPlans: LaunchPlan[]) {
     ]);
 }
 
-function useUnsupportedRequiredInputs() {}
-
 interface UseLaunchPlansForWorkflowArgs {
     workflowId?: WorkflowId | null;
     preferredLaunchPlanId?: Identifier;