From a8657075ba383ebe592420cefa137e04fb1eb038 Mon Sep 17 00:00:00 2001
From: James <james@union.ai>
Date: Tue, 31 May 2022 10:57:29 -0400
Subject: [PATCH 1/6] feat: support flyte deck #none

Signed-off-by: James <james@union.ai>
---
 .../ExecutionDetailsActions.tsx               | 76 ++++++++++++++++++-
 .../ExecutionDetails/ExecutionNodeDeck.tsx    | 17 +++++
 .../NodeExecutionDetailsPanelContent.tsx      |  7 +-
 .../Executions/ExecutionDetails/strings.tsx   |  1 +
 .../console/src/models/Execution/types.ts     |  1 +
 5 files changed, 92 insertions(+), 10 deletions(-)
 create mode 100644 packages/zapp/console/src/components/Executions/ExecutionDetails/ExecutionNodeDeck.tsx

diff --git a/packages/zapp/console/src/components/Executions/ExecutionDetails/ExecutionDetailsActions.tsx b/packages/zapp/console/src/components/Executions/ExecutionDetails/ExecutionDetailsActions.tsx
index e5251378f..d163a6ca2 100644
--- a/packages/zapp/console/src/components/Executions/ExecutionDetails/ExecutionDetailsActions.tsx
+++ b/packages/zapp/console/src/components/Executions/ExecutionDetails/ExecutionDetailsActions.tsx
@@ -1,23 +1,69 @@
-import { Button } from '@material-ui/core';
+import { Button, Dialog, DialogTitle, IconButton } from '@material-ui/core';
 import * as React from 'react';
 import { ResourceIdentifier, Identifier, Variable } from 'models/Common/types';
+import { makeStyles, Theme } from '@material-ui/core/styles';
 import { getTask } from 'models/Task/api';
 import { LaunchFormDialog } from 'components/Launch/LaunchForm/LaunchFormDialog';
 import { NodeExecutionIdentifier } from 'models/Execution/types';
 import { useNodeExecutionData } from 'components/hooks/useNodeExecution';
 import { literalsToLiteralValueMap } from 'components/Launch/LaunchForm/utils';
 import { TaskInitialLaunchParameters } from 'components/Launch/LaunchForm/types';
+import { NodeExecutionPhase } from 'models/Execution/enums';
+import Close from '@material-ui/icons/Close';
 import { NodeExecutionDetails } from '../types';
 import t from './strings';
+import { ExecutionNodeDeck } from './ExecutionNodeDeck';
+
+const useStyles = makeStyles((theme: Theme) => {
+  return {
+    actionsContainer: {
+      borderTop: `1px solid ${theme.palette.divider}`,
+      marginTop: theme.spacing(2),
+      paddingTop: theme.spacing(2),
+      '& button': {
+        marginRight: theme.spacing(1),
+      },
+    },
+    dialog: {
+      maxWidth: `calc(100% - ${theme.spacing(12)}px)`,
+      maxHeight: `calc(100% - ${theme.spacing(12)}px)`,
+      height: theme.spacing(90),
+      width: theme.spacing(100),
+      '& iframe': {
+        border: 'none',
+      },
+    },
+    dialogTitle: {
+      display: 'flex',
+      alignItems: 'center',
+      padding: theme.spacing(2),
+      paddingBottom: theme.spacing(0),
+    },
+    deckTitle: {
+      flexGrow: 1,
+      textAlign: 'center',
+      fontSize: '24px',
+      lineHeight: '28px',
+      marginBlock: 0,
+      paddingTop: theme.spacing(2),
+      paddingBottom: theme.spacing(2),
+    },
+    close: {
+      position: 'absolute',
+      right: theme.spacing(2),
+    },
+  };
+});
 
 interface ExecutionDetailsActionsProps {
-  className?: string;
   details: NodeExecutionDetails;
   nodeExecutionId: NodeExecutionIdentifier;
+  phase?: NodeExecutionPhase;
 }
 
 export const ExecutionDetailsActions = (props: ExecutionDetailsActionsProps): JSX.Element => {
-  const { className, details, nodeExecutionId } = props;
+  const { details, nodeExecutionId, phase } = props;
+  const styles = useStyles();
 
   const [showLaunchForm, setShowLaunchForm] = React.useState<boolean>(false);
   const [taskInputsTypes, setTaskInputsTypes] = React.useState<
@@ -36,6 +82,9 @@ export const ExecutionDetailsActions = (props: ExecutionDetailsActionsProps): JS
     if (id) fetchTask();
   }, [id]);
 
+  const [showDeck, setShowDeck] = React.useState(false);
+  const onCloseDeck = () => setShowDeck(false);
+
   if (!id) {
     return <></>;
   }
@@ -54,7 +103,15 @@ export const ExecutionDetailsActions = (props: ExecutionDetailsActionsProps): JS
 
   return (
     <>
-      <div className={className}>
+      <div className={styles.actionsContainer}>
+        <Button
+          variant="outlined"
+          color="primary"
+          onClick={() => setShowDeck(true)}
+          disabled={phase !== NodeExecutionPhase.SUCCEEDED}
+        >
+          {t('flyteDeck')}
+        </Button>
         <Button variant="outlined" color="primary" onClick={rerunOnClick}>
           {t('rerun')}
         </Button>
@@ -65,6 +122,17 @@ export const ExecutionDetailsActions = (props: ExecutionDetailsActionsProps): JS
         showLaunchForm={showLaunchForm}
         setShowLaunchForm={setShowLaunchForm}
       />
+      {nodeExecutionId && (
+        <Dialog PaperProps={{ className: styles.dialog }} maxWidth={false} open={showDeck}>
+          <div className={styles.dialogTitle}>
+            <h3 className={styles.deckTitle}>{t('flyteDeck')}</h3>
+            <IconButton aria-label="close" onClick={onCloseDeck} className={styles.close}>
+              <Close />
+            </IconButton>
+          </div>
+          <ExecutionNodeDeck nodeExecutionId={nodeExecutionId} />
+        </Dialog>
+      )}
     </>
   );
 };
diff --git a/packages/zapp/console/src/components/Executions/ExecutionDetails/ExecutionNodeDeck.tsx b/packages/zapp/console/src/components/Executions/ExecutionDetails/ExecutionNodeDeck.tsx
new file mode 100644
index 000000000..0bed47765
--- /dev/null
+++ b/packages/zapp/console/src/components/Executions/ExecutionDetails/ExecutionNodeDeck.tsx
@@ -0,0 +1,17 @@
+import { useNodeExecutionData } from 'components/hooks/useNodeExecution';
+import { NodeExecutionIdentifier } from 'models/Execution/types';
+import * as React from 'react';
+
+/** Fetches and renders the deck data for a given `NodeExecutionIdentifier` */
+export const ExecutionNodeDeck: React.FC<{ nodeExecutionId: NodeExecutionIdentifier }> = ({
+  nodeExecutionId,
+}) => {
+  const executionData = useNodeExecutionData(nodeExecutionId);
+  return (
+    <iframe
+      title="deck"
+      height="600"
+      src="https://deck-test2.tiiny.site/" // executionData.value.deckUri
+    />
+  );
+};
diff --git a/packages/zapp/console/src/components/Executions/ExecutionDetails/NodeExecutionDetailsPanelContent.tsx b/packages/zapp/console/src/components/Executions/ExecutionDetails/NodeExecutionDetailsPanelContent.tsx
index ee96d2c34..728a9fe58 100644
--- a/packages/zapp/console/src/components/Executions/ExecutionDetails/NodeExecutionDetailsPanelContent.tsx
+++ b/packages/zapp/console/src/components/Executions/ExecutionDetails/NodeExecutionDetailsPanelContent.tsx
@@ -94,11 +94,6 @@ const useStyles = makeStyles((theme: Theme) => {
       marginTop: theme.spacing(2),
       paddingTop: theme.spacing(2),
     },
-    actionsContainer: {
-      borderTop: `1px solid ${theme.palette.divider}`,
-      marginTop: theme.spacing(2),
-      paddingTop: theme.spacing(2),
-    },
     nodeTypeContent: {
       minWidth: theme.spacing(9),
     },
@@ -403,9 +398,9 @@ export const NodeExecutionDetailsPanelContent: React.FC<NodeExecutionDetailsProp
           {!dag && detailsContent}
           {details && (
             <ExecutionDetailsActions
-              className={styles.actionsContainer}
               details={details}
               nodeExecutionId={nodeExecutionId}
+              phase={nodeExecution?.closure.phase}
             />
           )}
         </div>
diff --git a/packages/zapp/console/src/components/Executions/ExecutionDetails/strings.tsx b/packages/zapp/console/src/components/Executions/ExecutionDetails/strings.tsx
index 4595ae70e..b94e31dcc 100644
--- a/packages/zapp/console/src/components/Executions/ExecutionDetails/strings.tsx
+++ b/packages/zapp/console/src/components/Executions/ExecutionDetails/strings.tsx
@@ -2,6 +2,7 @@ import { createLocalizedString } from '@flyteconsole/locale';
 
 const str = {
   rerun: 'RERUN',
+  flyteDeck: 'Flyte Deck',
 };
 
 export { patternKey } from '@flyteconsole/locale';
diff --git a/packages/zapp/console/src/models/Execution/types.ts b/packages/zapp/console/src/models/Execution/types.ts
index f03d5a4a4..bb2096bdd 100644
--- a/packages/zapp/console/src/models/Execution/types.ts
+++ b/packages/zapp/console/src/models/Execution/types.ts
@@ -138,5 +138,6 @@ export interface ExecutionData {
   outputs?: UrlBlob; // TODO FC#393: this field  was deprecated use fullOutputs instead - check for usage and remove
   fullInputs: LiteralMap | null;
   fullOutputs: LiteralMap | null;
+  deckUri?: string;
   dynamicWorkflow?: CompiledWorkflow;
 }

From 8486f5134d55baa3b3f2881a02c51dd73238ed02 Mon Sep 17 00:00:00 2001
From: James <james@union.ai>
Date: Wed, 8 Jun 2022 00:26:39 -0400
Subject: [PATCH 2/6] fix: rebase with master #none

Signed-off-by: James <james@union.ai>
---
 packages/zapp/console/package.json            |  2 +-
 .../ExecutionDetailsActions.tsx               | 11 ++--
 .../ExecutionDetails/ExecutionNodeDeck.tsx    | 21 +++----
 .../src/components/hooks/useDataProxy.ts      | 17 ++++++
 .../console/src/models/Common/constants.ts    |  1 +
 .../zapp/console/src/models/Execution/api.ts  | 14 ++++-
 .../console/src/models/Execution/types.ts     |  8 ++-
 .../console/src/models/Execution/utils.ts     |  4 ++
 yarn.lock                                     | 59 +++----------------
 9 files changed, 65 insertions(+), 72 deletions(-)
 create mode 100644 packages/zapp/console/src/components/hooks/useDataProxy.ts

diff --git a/packages/zapp/console/package.json b/packages/zapp/console/package.json
index 055000982..d9ce996d5 100644
--- a/packages/zapp/console/package.json
+++ b/packages/zapp/console/package.json
@@ -58,7 +58,7 @@
         "@commitlint/cli": "^8.3.5",
         "@commitlint/config-conventional": "^8.3.4",
         "@date-io/moment": "1.3.9",
-        "@flyteorg/flyteidl": "1.1.0",
+        "@flyteorg/flyteidl": "1.1.4",
         "@material-ui/core": "^4.0.0",
         "@material-ui/icons": "^4.0.0",
         "@material-ui/pickers": "^3.2.2",
diff --git a/packages/zapp/console/src/components/Executions/ExecutionDetails/ExecutionDetailsActions.tsx b/packages/zapp/console/src/components/Executions/ExecutionDetails/ExecutionDetailsActions.tsx
index d163a6ca2..3df5bfbdd 100644
--- a/packages/zapp/console/src/components/Executions/ExecutionDetails/ExecutionDetailsActions.tsx
+++ b/packages/zapp/console/src/components/Executions/ExecutionDetails/ExecutionDetailsActions.tsx
@@ -1,11 +1,11 @@
-import { Button, Dialog, DialogTitle, IconButton } from '@material-ui/core';
+import { Button, Dialog, IconButton } from '@material-ui/core';
 import * as React from 'react';
 import { ResourceIdentifier, Identifier, Variable } from 'models/Common/types';
 import { makeStyles, Theme } from '@material-ui/core/styles';
 import { getTask } from 'models/Task/api';
 import { LaunchFormDialog } from 'components/Launch/LaunchForm/LaunchFormDialog';
 import { NodeExecutionIdentifier } from 'models/Execution/types';
-import { useNodeExecutionData } from 'components/hooks/useNodeExecution';
+import { useNodeExecution, useNodeExecutionData } from 'components/hooks/useNodeExecution';
 import { literalsToLiteralValueMap } from 'components/Launch/LaunchForm/utils';
 import { TaskInitialLaunchParameters } from 'components/Launch/LaunchForm/types';
 import { NodeExecutionPhase } from 'models/Execution/enums';
@@ -71,6 +71,7 @@ export const ExecutionDetailsActions = (props: ExecutionDetailsActionsProps): JS
   >();
 
   const executionData = useNodeExecutionData(nodeExecutionId);
+  const execution = useNodeExecution(nodeExecutionId);
 
   const id = details.taskTemplate?.id as ResourceIdentifier | undefined;
 
@@ -122,7 +123,7 @@ export const ExecutionDetailsActions = (props: ExecutionDetailsActionsProps): JS
         showLaunchForm={showLaunchForm}
         setShowLaunchForm={setShowLaunchForm}
       />
-      {nodeExecutionId && (
+      {nodeExecutionId && execution?.value?.closure?.deckUri ? (
         <Dialog PaperProps={{ className: styles.dialog }} maxWidth={false} open={showDeck}>
           <div className={styles.dialogTitle}>
             <h3 className={styles.deckTitle}>{t('flyteDeck')}</h3>
@@ -130,9 +131,9 @@ export const ExecutionDetailsActions = (props: ExecutionDetailsActionsProps): JS
               <Close />
             </IconButton>
           </div>
-          <ExecutionNodeDeck nodeExecutionId={nodeExecutionId} />
+          <ExecutionNodeDeck deckUri={execution.value.closure.deckUri} />
         </Dialog>
-      )}
+      ) : null}
     </>
   );
 };
diff --git a/packages/zapp/console/src/components/Executions/ExecutionDetails/ExecutionNodeDeck.tsx b/packages/zapp/console/src/components/Executions/ExecutionDetails/ExecutionNodeDeck.tsx
index 0bed47765..2defd39db 100644
--- a/packages/zapp/console/src/components/Executions/ExecutionDetails/ExecutionNodeDeck.tsx
+++ b/packages/zapp/console/src/components/Executions/ExecutionDetails/ExecutionNodeDeck.tsx
@@ -1,17 +1,14 @@
-import { useNodeExecutionData } from 'components/hooks/useNodeExecution';
-import { NodeExecutionIdentifier } from 'models/Execution/types';
+import { useDownloadLocation } from 'components/hooks/useDataProxy';
+import { WaitForData } from 'components/common/WaitForData';
 import * as React from 'react';
 
-/** Fetches and renders the deck data for a given `NodeExecutionIdentifier` */
-export const ExecutionNodeDeck: React.FC<{ nodeExecutionId: NodeExecutionIdentifier }> = ({
-  nodeExecutionId,
-}) => {
-  const executionData = useNodeExecutionData(nodeExecutionId);
+/** Fetches and renders the deck data for a given `deckUri` */
+export const ExecutionNodeDeck: React.FC<{ deckUri: string }> = ({ deckUri }) => {
+  const downloadLocation = useDownloadLocation(deckUri);
+
   return (
-    <iframe
-      title="deck"
-      height="600"
-      src="https://deck-test2.tiiny.site/" // executionData.value.deckUri
-    />
+    <WaitForData {...downloadLocation}>
+      <iframe title="deck" height="600" src={downloadLocation.value.signedUrl} />
+    </WaitForData>
   );
 };
diff --git a/packages/zapp/console/src/components/hooks/useDataProxy.ts b/packages/zapp/console/src/components/hooks/useDataProxy.ts
new file mode 100644
index 000000000..cc372d4bf
--- /dev/null
+++ b/packages/zapp/console/src/components/hooks/useDataProxy.ts
@@ -0,0 +1,17 @@
+import { useAPIContext } from 'components/data/apiContext';
+import { DownloadLocation } from 'models/Execution/types';
+import { FetchableData } from './types';
+import { useFetchableData } from './useFetchableData';
+
+/** A hook for fetching a NodeExecution */
+export function useDownloadLocation(nativeUrl: string): FetchableData<DownloadLocation> {
+  const { getDownloadLocation } = useAPIContext();
+  return useFetchableData<DownloadLocation, string>(
+    {
+      debugName: 'CreateDownloadLocation',
+      defaultValue: {} as DownloadLocation,
+      doFetch: (nativeUrl) => getDownloadLocation(nativeUrl),
+    },
+    nativeUrl,
+  );
+}
diff --git a/packages/zapp/console/src/models/Common/constants.ts b/packages/zapp/console/src/models/Common/constants.ts
index f011b0727..8ec7a5a28 100644
--- a/packages/zapp/console/src/models/Common/constants.ts
+++ b/packages/zapp/console/src/models/Common/constants.ts
@@ -14,6 +14,7 @@ export const endpointPrefixes = {
   taskExecution: '/task_executions',
   taskExecutionChildren: '/children/task_executions',
   workflow: '/workflows',
+  dataProxyArtifactUrn: '/dataproxy/artifact_urn',
 };
 
 export const identifierPrefixes: { [k in ResourceType]: string } = {
diff --git a/packages/zapp/console/src/models/Execution/api.ts b/packages/zapp/console/src/models/Execution/api.ts
index 07ced0629..3eff83011 100644
--- a/packages/zapp/console/src/models/Execution/api.ts
+++ b/packages/zapp/console/src/models/Execution/api.ts
@@ -1,4 +1,4 @@
-import { Admin, Core, Protobuf } from 'flyteidl';
+import { Admin, Core, Protobuf, Service } from 'flyteidl';
 import { getAdminEntity, postAdminEntity } from 'models/AdminEntity/AdminEntity';
 import {
   defaultListExecutionChildrenConfig,
@@ -11,6 +11,7 @@ import { makeIdentifierPath } from 'models/Common/utils';
 import { defaultExecutionPrincipal } from './constants';
 import { ExecutionState } from './enums';
 import {
+  DownloadLocation,
   Execution,
   ExecutionData,
   ExecutionMetadata,
@@ -22,6 +23,7 @@ import {
 } from './types';
 import {
   executionListTransformer,
+  makeCreateDownloadLocationPath,
   makeExecutionPath,
   makeNodeExecutionListPath,
   makeNodeExecutionPath,
@@ -56,6 +58,16 @@ export const getExecution = (id: WorkflowExecutionIdentifier, config?: RequestCo
     config,
   );
 
+/** Fetches a signed url of the native url */
+export const getDownloadLocation = (nativeUrl: string, config?: RequestConfig) =>
+  getAdminEntity<Service.CreateDownloadLocationRequest, DownloadLocation>(
+    {
+      path: makeCreateDownloadLocationPath(nativeUrl),
+      messageType: Service.CreateDownloadLocationRequest,
+    },
+    config,
+  );
+
 const emptyExecutionData: ExecutionData = {
   inputs: {},
   outputs: {},
diff --git a/packages/zapp/console/src/models/Execution/types.ts b/packages/zapp/console/src/models/Execution/types.ts
index bb2096bdd..0ac356e58 100644
--- a/packages/zapp/console/src/models/Execution/types.ts
+++ b/packages/zapp/console/src/models/Execution/types.ts
@@ -1,4 +1,4 @@
-import { Admin, Core, Event, Protobuf } from 'flyteidl';
+import { Admin, Core, Event, Protobuf, Service } from 'flyteidl';
 import { Identifier, LiteralMap, LiteralMapBlob, TaskLog, UrlBlob } from 'models/Common/types';
 import { CompiledWorkflow } from 'models/Workflow/types';
 import {
@@ -55,6 +55,11 @@ export interface Execution extends Admin.IExecution {
   spec: ExecutionSpec;
 }
 
+export interface DownloadLocation extends Service.CreateDownloadLocationResponse {
+  signedUrl: string;
+  expiresAt: Protobuf.ITimestamp;
+}
+
 /** Node executions */
 export interface WorkflowNodeMetadata {
   executionId: WorkflowExecutionIdentifier;
@@ -102,6 +107,7 @@ export interface NodeExecutionClosure extends Admin.INodeExecutionClosure {
   startedAt?: Protobuf.ITimestamp;
   taskNodeMetadata?: TaskNodeMetadata;
   workflowNodeMetadata?: WorkflowNodeMetadata;
+  deckUri?: string;
 }
 
 /** Task executions */
diff --git a/packages/zapp/console/src/models/Execution/utils.ts b/packages/zapp/console/src/models/Execution/utils.ts
index 0e892d180..95ae864c5 100644
--- a/packages/zapp/console/src/models/Execution/utils.ts
+++ b/packages/zapp/console/src/models/Execution/utils.ts
@@ -79,6 +79,10 @@ export const makeTaskExecutionPath = ({
     retryAttempt,
   ].join('/');
 
+/** Generates the API endpoint for the CreateDownloadLocation request */
+export const makeCreateDownloadLocationPath = (nativeUrl: string) =>
+  `${endpointPrefixes.dataProxyArtifactUrn}?native_url=${nativeUrl}`;
+
 /** Transformer to coerce an `Admin.ExecutionList` into a standard shape */
 export const executionListTransformer = createPaginationTransformer<Execution, Admin.ExecutionList>(
   'executions',
diff --git a/yarn.lock b/yarn.lock
index 6b1636e85..9f5e82759 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -1650,10 +1650,10 @@
     minimatch "^3.1.2"
     strip-json-comments "^3.1.1"
 
-"@flyteorg/flyteidl@1.1.0":
-  version "1.1.0"
-  resolved "https://registry.yarnpkg.com/@flyteorg/flyteidl/-/flyteidl-1.1.0.tgz#9fcf06d878616439939e932c5a35357d3d7eea04"
-  integrity sha512-p07Vd6rxmASKJvfF56ArVyuZLjxTJPnAQsTs3rDJL74gd9Ixs4cEDa/A4+iMYSNl42iTVPvAkM4movXDD1Hmgg==
+"@flyteorg/flyteidl@1.1.4":
+  version "1.1.4"
+  resolved "https://registry.yarnpkg.com/@flyteorg/flyteidl/-/flyteidl-1.1.4.tgz#7a02d80e22c623817b6061f1f5e88ec243041cf1"
+  integrity sha512-CmO/H3vbjluV/G4J9TFnSo3HiefOQ8f46BbpordSlVA2CANWQZaNc6Csz7JTGdotyZ2DdUXJkBcPRiA/r9H3lQ==
 
 "@gar/promisify@^1.0.1":
   version "1.1.3"
@@ -5236,7 +5236,7 @@ array-includes@^3.0.3, array-includes@^3.1.3, array-includes@^3.1.4:
     get-intrinsic "^1.1.1"
     is-string "^1.0.7"
 
-array-union@^1.0.1, array-union@^1.0.2:
+array-union@^1.0.2:
   version "1.0.2"
   resolved "https://registry.yarnpkg.com/array-union/-/array-union-1.0.2.tgz#9a34410e4f4e3da23dea375be5be70f24778ec39"
   integrity sha1-mjRBDk9OPaI96jdb5b5w8kd47Dk=
@@ -6616,13 +6616,6 @@ clean-stack@^2.0.0:
   resolved "https://registry.yarnpkg.com/clean-stack/-/clean-stack-2.2.0.tgz#ee8472dbb129e727b31e8a10a427dee9dfe4008b"
   integrity sha512-4diC9HaTE+KRAMWhDhrGOECgWZxoevMc5TlkObMqNSsVU62PYzXZ/SMTjzyGAFF1YusgxGcSWTEXBhp0CPwQ1A==
 
-clean-webpack-plugin@^4.0.0:
-  version "4.0.0"
-  resolved "https://registry.yarnpkg.com/clean-webpack-plugin/-/clean-webpack-plugin-4.0.0.tgz#72947d4403d452f38ed61a9ff0ada8122aacd729"
-  integrity sha512-WuWE1nyTNAyW5T7oNyys2EN0cfP2fdRxhxnIQWiAp0bMabPdHhoGxM8A6YL2GhqwgrPnnaemVE7nv5XJ2Fhh2w==
-  dependencies:
-    del "^4.1.1"
-
 cli-boxes@^1.0.0:
   version "1.0.0"
   resolved "https://registry.yarnpkg.com/cli-boxes/-/cli-boxes-1.0.0.tgz#4fa917c3e59c94a004cd61f8ee509da651687143"
@@ -8105,19 +8098,6 @@ define-property@^2.0.2:
     is-descriptor "^1.0.2"
     isobject "^3.0.1"
 
-del@^4.1.1:
-  version "4.1.1"
-  resolved "https://registry.yarnpkg.com/del/-/del-4.1.1.tgz#9e8f117222ea44a31ff3a156c049b99052a9f0b4"
-  integrity sha512-QwGuEUouP2kVwQenAsOof5Fv8K9t3D8Ca8NxcXKrIpEHjTXK5J2nXLdP+ALI1cgv8wj7KuwBhTwBkOZSJKM5XQ==
-  dependencies:
-    "@types/glob" "^7.1.1"
-    globby "^6.1.0"
-    is-path-cwd "^2.0.0"
-    is-path-in-cwd "^2.0.0"
-    p-map "^2.0.0"
-    pify "^4.0.1"
-    rimraf "^2.6.3"
-
 del@^6.0.0:
   version "6.0.0"
   resolved "https://registry.yarnpkg.com/del/-/del-6.0.0.tgz#0b40d0332cea743f1614f818be4feb717714c952"
@@ -10289,7 +10269,7 @@ glob-to-regexp@^0.4.1:
   resolved "https://registry.yarnpkg.com/glob-to-regexp/-/glob-to-regexp-0.4.1.tgz#c75297087c851b9a578bd217dd59a92f59fe546e"
   integrity sha512-lkX1HJXwyMcprw/5YUZc2s7DrpAiHB21/V+E1rHUrVNokkvB6bqMzT0VfV6/86ZNabt1k14YOIaT7nDvOX3Iiw==
 
-glob@^7.0.0, glob@^7.0.3:
+glob@^7.0.0:
   version "7.2.3"
   resolved "https://registry.yarnpkg.com/glob/-/glob-7.2.3.tgz#b8df0fb802bbfa8e89bd1d938b4e16578ed44f2b"
   integrity sha512-nFR0zLpU2YCaRxwoCJvL6UvCH2JFyFVIvwTLsIf21AuHlMskA1hhTdk+LlYJtOlYt9v6dvszD2BGRqBL+iQK9Q==
@@ -10378,17 +10358,6 @@ globby@^11.0.2, globby@^11.0.4:
     merge2 "^1.4.1"
     slash "^3.0.0"
 
-globby@^6.1.0:
-  version "6.1.0"
-  resolved "https://registry.yarnpkg.com/globby/-/globby-6.1.0.tgz#f5a6d70e8395e21c858fb0489d64df02424d506c"
-  integrity sha512-KVbFv2TQtbzCoxAnfD6JcHZTYCzyliEaaeM/gH8qQdkKr5s0OP9scEgvdcngyk7AVdY6YVW/TJHd+lQ/Df3Daw==
-  dependencies:
-    array-union "^1.0.1"
-    glob "^7.0.3"
-    object-assign "^4.0.1"
-    pify "^2.0.0"
-    pinkie-promise "^2.0.0"
-
 globby@^9.2.0:
   version "9.2.0"
   resolved "https://registry.yarnpkg.com/globby/-/globby-9.2.0.tgz#fd029a706c703d29bdd170f4b6db3a3f7a7cb63d"
@@ -11649,18 +11618,11 @@ is-observable@^1.1.0:
   dependencies:
     symbol-observable "^1.1.0"
 
-is-path-cwd@^2.0.0, is-path-cwd@^2.2.0:
+is-path-cwd@^2.2.0:
   version "2.2.0"
   resolved "https://registry.yarnpkg.com/is-path-cwd/-/is-path-cwd-2.2.0.tgz#67d43b82664a7b5191fd9119127eb300048a9fdb"
   integrity sha512-w942bTcih8fdJPJmQHFzkS76NEP8Kzzvmw92cXsazb8intwLqPibPPdXf4ANdKV3rYMuuQYGIWtvz9JilB3NFQ==
 
-is-path-in-cwd@^2.0.0:
-  version "2.1.0"
-  resolved "https://registry.yarnpkg.com/is-path-in-cwd/-/is-path-in-cwd-2.1.0.tgz#bfe2dca26c69f397265a4009963602935a053acb"
-  integrity sha512-rNocXHgipO+rvnP6dk3zI20RpOtrAM/kzbB258Uw5BWr3TpXi861yzjo16Dn4hUox07iw5AyeMLHWsujkjzvRQ==
-  dependencies:
-    is-path-inside "^2.1.0"
-
 is-path-inside@^1.0.0:
   version "1.0.1"
   resolved "https://registry.yarnpkg.com/is-path-inside/-/is-path-inside-1.0.1.tgz#8ef5b7de50437a3fdca6b4e865ef7aa55cb48036"
@@ -11668,13 +11630,6 @@ is-path-inside@^1.0.0:
   dependencies:
     path-is-inside "^1.0.1"
 
-is-path-inside@^2.1.0:
-  version "2.1.0"
-  resolved "https://registry.yarnpkg.com/is-path-inside/-/is-path-inside-2.1.0.tgz#7c9810587d659a40d27bcdb4d5616eab059494b2"
-  integrity sha512-wiyhTzfDWsvwAW53OBWF5zuvaOGlZ6PwYxAbPVDhpm+gM09xKQGjBq/8uYN12aDvMxnAnq3dxTyoSoRNmg5YFg==
-  dependencies:
-    path-is-inside "^1.0.2"
-
 is-path-inside@^3.0.2:
   version "3.0.2"
   resolved "https://registry.yarnpkg.com/is-path-inside/-/is-path-inside-3.0.2.tgz#f5220fc82a3e233757291dddc9c5877f2a1f3017"

From ec1e84b738fbff7053844ac5a437b8d9a8a1aecf Mon Sep 17 00:00:00 2001
From: James <james@union.ai>
Date: Mon, 6 Jun 2022 08:08:11 -0400
Subject: [PATCH 3/6] fix: fix iframe height and api response type; #none

Signed-off-by: James <james@union.ai>
---
 .../Executions/ExecutionDetails/ExecutionNodeDeck.tsx         | 2 +-
 packages/zapp/console/src/models/Execution/api.ts             | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/packages/zapp/console/src/components/Executions/ExecutionDetails/ExecutionNodeDeck.tsx b/packages/zapp/console/src/components/Executions/ExecutionDetails/ExecutionNodeDeck.tsx
index 2defd39db..e0b702915 100644
--- a/packages/zapp/console/src/components/Executions/ExecutionDetails/ExecutionNodeDeck.tsx
+++ b/packages/zapp/console/src/components/Executions/ExecutionDetails/ExecutionNodeDeck.tsx
@@ -8,7 +8,7 @@ export const ExecutionNodeDeck: React.FC<{ deckUri: string }> = ({ deckUri }) =>
 
   return (
     <WaitForData {...downloadLocation}>
-      <iframe title="deck" height="600" src={downloadLocation.value.signedUrl} />
+      <iframe title="deck" height="100%" src={downloadLocation.value.signedUrl} />
     </WaitForData>
   );
 };
diff --git a/packages/zapp/console/src/models/Execution/api.ts b/packages/zapp/console/src/models/Execution/api.ts
index 3eff83011..9aa39a11d 100644
--- a/packages/zapp/console/src/models/Execution/api.ts
+++ b/packages/zapp/console/src/models/Execution/api.ts
@@ -60,10 +60,10 @@ export const getExecution = (id: WorkflowExecutionIdentifier, config?: RequestCo
 
 /** Fetches a signed url of the native url */
 export const getDownloadLocation = (nativeUrl: string, config?: RequestConfig) =>
-  getAdminEntity<Service.CreateDownloadLocationRequest, DownloadLocation>(
+  getAdminEntity<Service.CreateDownloadLocationResponse, DownloadLocation>(
     {
       path: makeCreateDownloadLocationPath(nativeUrl),
-      messageType: Service.CreateDownloadLocationRequest,
+      messageType: Service.CreateDownloadLocationResponse,
     },
     config,
   );

From ef1f2caa6502e3d7610d08a2c3cc866aba95f8f8 Mon Sep 17 00:00:00 2001
From: James <james@union.ai>
Date: Mon, 6 Jun 2022 08:53:52 -0400
Subject: [PATCH 4/6] fix: modal style; #none;

Signed-off-by: James <james@union.ai>
---
 .../ExecutionDetailsActions.tsx               | 25 +++++++++++--------
 1 file changed, 14 insertions(+), 11 deletions(-)

diff --git a/packages/zapp/console/src/components/Executions/ExecutionDetails/ExecutionDetailsActions.tsx b/packages/zapp/console/src/components/Executions/ExecutionDetails/ExecutionDetailsActions.tsx
index 3df5bfbdd..2a5968268 100644
--- a/packages/zapp/console/src/components/Executions/ExecutionDetails/ExecutionDetailsActions.tsx
+++ b/packages/zapp/console/src/components/Executions/ExecutionDetails/ExecutionDetailsActions.tsx
@@ -28,7 +28,7 @@ const useStyles = makeStyles((theme: Theme) => {
       maxWidth: `calc(100% - ${theme.spacing(12)}px)`,
       maxHeight: `calc(100% - ${theme.spacing(12)}px)`,
       height: theme.spacing(90),
-      width: theme.spacing(100),
+      width: theme.spacing(110),
       '& iframe': {
         border: 'none',
       },
@@ -38,12 +38,13 @@ const useStyles = makeStyles((theme: Theme) => {
       alignItems: 'center',
       padding: theme.spacing(2),
       paddingBottom: theme.spacing(0),
+      fontFamily: 'Open sans',
     },
     deckTitle: {
       flexGrow: 1,
       textAlign: 'center',
       fontSize: '24px',
-      lineHeight: '28px',
+      lineHeight: '32px',
       marginBlock: 0,
       paddingTop: theme.spacing(2),
       paddingBottom: theme.spacing(2),
@@ -105,14 +106,16 @@ export const ExecutionDetailsActions = (props: ExecutionDetailsActionsProps): JS
   return (
     <>
       <div className={styles.actionsContainer}>
-        <Button
-          variant="outlined"
-          color="primary"
-          onClick={() => setShowDeck(true)}
-          disabled={phase !== NodeExecutionPhase.SUCCEEDED}
-        >
-          {t('flyteDeck')}
-        </Button>
+        {execution?.value?.closure?.deckUri && (
+          <Button
+            variant="outlined"
+            color="primary"
+            onClick={() => setShowDeck(true)}
+            disabled={phase !== NodeExecutionPhase.SUCCEEDED}
+          >
+            {t('flyteDeck')}
+          </Button>
+        )}
         <Button variant="outlined" color="primary" onClick={rerunOnClick}>
           {t('rerun')}
         </Button>
@@ -123,7 +126,7 @@ export const ExecutionDetailsActions = (props: ExecutionDetailsActionsProps): JS
         showLaunchForm={showLaunchForm}
         setShowLaunchForm={setShowLaunchForm}
       />
-      {nodeExecutionId && execution?.value?.closure?.deckUri ? (
+      {execution?.value?.closure?.deckUri ? (
         <Dialog PaperProps={{ className: styles.dialog }} maxWidth={false} open={showDeck}>
           <div className={styles.dialogTitle}>
             <h3 className={styles.deckTitle}>{t('flyteDeck')}</h3>

From 04973af1616f02a02bc6d45d09377265a124d494 Mon Sep 17 00:00:00 2001
From: James <james@union.ai>
Date: Wed, 8 Jun 2022 00:24:53 -0400
Subject: [PATCH 5/6] fix: use env variable for server ssl config #none;

Signed-off-by: James <james@union.ai>
---
 packages/zapp/console/webpack.dev.config.ts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/packages/zapp/console/webpack.dev.config.ts b/packages/zapp/console/webpack.dev.config.ts
index 642fc97a8..153cd2587 100644
--- a/packages/zapp/console/webpack.dev.config.ts
+++ b/packages/zapp/console/webpack.dev.config.ts
@@ -2,7 +2,7 @@ import * as webpack from 'webpack';
 import * as HTMLWebpackPlugin from 'html-webpack-plugin';
 import * as path from 'path';
 import chalk from 'chalk';
-import { LOCAL_DEV_HOST, CERTIFICATE_PATH } from './env';
+import { LOCAL_DEV_HOST, CERTIFICATE_PATH, ADMIN_API_USE_SSL } from './env';
 
 const { merge } = require('webpack-merge');
 const fs = require('fs');
@@ -42,7 +42,7 @@ export const clientConfig: webpack.Configuration = merge(common.default.clientCo
     host: LOCAL_DEV_HOST,
     historyApiFallback: true,
     server: {
-      type: 'https',
+      type: ADMIN_API_USE_SSL,
       options: {
         key: fs.readFileSync(`${CERTIFICATE_PATH}/server.key`),
         cert: fs.readFileSync(`${CERTIFICATE_PATH}/server.crt`),

From be338699c6248af19557abf632640f9398e015b3 Mon Sep 17 00:00:00 2001
From: James <james@union.ai>
Date: Wed, 8 Jun 2022 13:21:43 -0400
Subject: [PATCH 6/6] fix: use h2 instead of h3 for future migration #none

Signed-off-by: James <james@union.ai>
---
 .../Executions/ExecutionDetails/ExecutionDetailsActions.tsx     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/zapp/console/src/components/Executions/ExecutionDetails/ExecutionDetailsActions.tsx b/packages/zapp/console/src/components/Executions/ExecutionDetails/ExecutionDetailsActions.tsx
index 2a5968268..8177f5066 100644
--- a/packages/zapp/console/src/components/Executions/ExecutionDetails/ExecutionDetailsActions.tsx
+++ b/packages/zapp/console/src/components/Executions/ExecutionDetails/ExecutionDetailsActions.tsx
@@ -129,7 +129,7 @@ export const ExecutionDetailsActions = (props: ExecutionDetailsActionsProps): JS
       {execution?.value?.closure?.deckUri ? (
         <Dialog PaperProps={{ className: styles.dialog }} maxWidth={false} open={showDeck}>
           <div className={styles.dialogTitle}>
-            <h3 className={styles.deckTitle}>{t('flyteDeck')}</h3>
+            <h2 className={styles.deckTitle}>{t('flyteDeck')}</h2>
             <IconButton aria-label="close" onClick={onCloseDeck} className={styles.close}>
               <Close />
             </IconButton>